Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brings the Java API for WriteBatch inline with the C++ API #3550

Closed
wants to merge 3 commits into from
Closed

Brings the Java API for WriteBatch inline with the C++ API #3550

wants to merge 3 commits into from

Conversation

adamretter
Copy link
Collaborator

  • Exposes status
  • Corrects some method naming
  • Adds missing functionality

@adamretter
Copy link
Collaborator Author

adamretter commented Mar 1, 2018 •
edited

So I have a couple failing tests around PopSavePoint(). I am struggling to understand if popSavePoint is meant to restore the state back to the previous SetSavePoint(). For example, this test fails: https://github.com/facebook/rocksdb/pull/3550/files#diff-7a9f076b512aaa9442c89c549241c359R348

Can someone explain PopSavePoint() please?

@facebook-github-bot
Copy link
Contributor

@adamretter has updated the pull request.

@facebook-github-bot
Copy link
Contributor

@adamretter has updated the pull request.

@facebook-github-bot
Copy link
Contributor

@adamretter has updated the pull request.

facebook-github-bot
facebook-github-bot reviewed Mar 2, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Mar 2, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagar0 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

sagar0 pushed a commit that referenced this pull request Mar 5, 2018
@adamretter @sagar0
Brings the Java API for WriteBatch inline with the C++ API
1983e30 
Summary:
* Exposes status
* Corrects some method naming
* Adds missing functionality
Closes #3550

Differential Revision: D7140790

Pulled By: sagar0

fbshipit-source-id: cbdab6c5a7ae4f3030fb46739e9060e381b26fa6
sagar0 pushed a commit that referenced this pull request Mar 15, 2018
@adamretter @sagar0
Brings the Java API for WriteBatch inline with the C++ API
5ae32b8 
Summary:
* Exposes status
* Corrects some method naming
* Adds missing functionality
Closes #3550

Differential Revision: D7140790

Pulled By: sagar0

fbshipit-source-id: cbdab6c5a7ae4f3030fb46739e9060e381b26fa6
@adamretter adamretter deleted the writebatch-cleanup branch April 6, 2018 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Assignees
No one assigned
Labels
CLA Signed enhancement java-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamretter @facebook-github-bot