Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PrefixExtractorChanged: pass raw pointer instead shared_ptr #3937

Closed

Conversation

@miasantreble
Copy link
Contributor

miasantreble commented Jun 1, 2018

This should resolve the performance regression caused by the unnecessary copying of the shared_ptr.

@miasantreble miasantreble requested a review from siying Jun 1, 2018
Copy link

facebook-github-bot left a comment

@miasantreble has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@siying
siying approved these changes Jun 1, 2018
Copy link

facebook-github-bot left a comment

@miasantreble is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@miasantreble miasantreble deleted the miasantreble:fix-viewstate-regression branch Jun 1, 2018
maysamyabandeh added a commit that referenced this pull request Jul 10, 2018
Summary:
This should resolve the performance regression caused by the unnecessary copying of the shared_ptr.
Closes #3937

Differential Revision: D8232330

Pulled By: miasantreble

fbshipit-source-id: 7885bf7cd190b6f87164c52d6edd328298c13f97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.