Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all unique/shared_ptr instances to be qualified with std:: #4638

Closed
wants to merge 1 commit into from

Conversation

sagar0
Copy link
Contributor

@sagar0 sagar0 commented Nov 6, 2018

Ran the following commands to recursively change all the files under RocksDB:

find . -type f -name "*.[cc,h]" -exec sed -i 's/ unique_ptr/ std::unique_ptr/g' {} +
find . -type f -name "*.[cc,h]" -exec sed -i 's/<unique_ptr/<std::unique_ptr/g' {} +
find . -type f -name "*.[cc,h]" -exec sed -i 's/ shared_ptr/ std::shared_ptr/g' {} +
find . -type f -name "*.[cc,h]" -exec sed -i 's/<shared_ptr/<std::shared_ptr/g' {} +

Running make format updated some formatting on the files touched.

Test plan:
make format
make check

@sagar0 sagar0 changed the title Update all instances of unique/shared_ptr to be qualified with namespace std Update all unique/shared_ptr instances to be qualified with namespace std Nov 6, 2018
@sagar0 sagar0 requested a review from siying November 6, 2018 01:08
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@sagar0 sagar0 changed the title Update all unique/shared_ptr instances to be qualified with namespace std Update all unique/shared_ptr instances to be qualified with std:: Nov 6, 2018
Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only skimmed it, lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants