Remove a printf from db_stress that's not useful info #6705
Conversation
There was a problem hiding this comment.
@anand1976 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@anand1976 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| @@ -453,8 +453,7 @@ def whitebox_crash_main(args, unknown_args): | |||
|
|
|||
| stdoutdata = stdoutdata.lower() | |||
| errorcount = (stdoutdata.count('error') - | |||
| stdoutdata.count('got errors 0 times') - | |||
| stdoutdata.count('got expected errors 0 times')) | |||
There was a problem hiding this comment.
I think the problem might actually be this line: if the errors are expected, we shouldn't expect the number to be zero, no? That is, we might consider keeping the message in db_stress_stat.h and simply remove the 0 times part from here so that any number of expected errors are ignored.
There was a problem hiding this comment.
I thought of doing that initially, but I don't think that print tells us anything useful anyway.
There was a problem hiding this comment.
@anand1976 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@anand1976 merged this pull request in 610a09c. |
This was causing db_crashtest.py to wrongly assume an error by parsing the output. Hopefully this will stabilize the crash tests.
Test:
make blackbox_crash_test