Jump to conversation
Unresolved conversations (5)
@mrambacher mrambacher Oct 28, 2021
nit: Should this be an int or one of the string values of the checksum enum?
tools/db_bench_tool.cc
pdillinger
@mrambacher mrambacher Oct 28, 2021
Please add a comment that this is corrupting the checksum type to "123.*" for line 2231 below
Outdated
table/table_test.cc
@mrambacher mrambacher Oct 25, 2021
Just asking if this should be a set or vector? Wonder if at some point the same enum might have two names...
Outdated
options/options_helper.cc
pdillinger
@mrambacher mrambacher Oct 25, 2021
Should there be (either here or using a Validator) some check that the checksum_type is a valid type?
tools/db_bench_tool.cc
pdillinger
@mrambacher mrambacher Oct 25, 2021
Is there a reason these cases are no longer part of the test? Can you add a comment somewhere (either in the code or the PR message) as to why this change was made?
db/db_test_util.cc
pdillinger
Resolved conversations (0)