{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":41693388,"defaultBranch":"main","name":"screenshot-tests-for-android","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-08-31T18:36:02.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1643925705.733718","currentOid":""},"activityList":{"items":[{"before":"03124ba42658fee5581e713a49a388bece8cdf98","after":"eb81a2d74f80648bd4595fef364848f2babffcce","ref":"refs/heads/main","pushedAt":"2024-03-23T23:14:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Migrate google java format from 1.7 -> 1.21.0 (#324)\n\nSummary:\nX-link: https://github.com/facebookexternal/OculusManufacturing/pull/524\n\nX-link: https://github.com/facebookexternal/fbpay/pull/3\n\nPull Request resolved: https://github.com/facebook/screenshot-tests-for-android/pull/324\n\nX-link: https://github.com/pytorch/executorch/pull/1771\n\nX-link: https://github.com/facebook/igl/pull/68\n\nX-link: https://github.com/facebook/mariana-trench/pull/153\n\nX-link: https://github.com/facebook/fresco/pull/2757\n\nX-link: https://github.com/facebook/litho/pull/974\n\nX-link: https://github.com/facebook/react-native/pull/42754\n\nX-link: https://github.com/facebook/hhvm/pull/9431\n\nX-link: https://github.com/WhatsApp/eqwalizer/pull/52\n\nX-link: https://github.com/facebookincubator/spectrum/pull/1858\n\nX-link: https://github.com/fbsamples/metapay/pull/1\n\nX-link: https://github.com/facebookincubator/fbjni/pull/95\n\nX-link: https://github.com/facebookincubator/Battery-Metrics/pull/30\n\nX-link: https://github.com/facebook/ktfmt/pull/440\n\nX-link: https://github.com/facebook/flipper/pull/5456\n\nX-link: https://github.com/facebook/hermes/pull/1290\n\nX-link: https://github.com/facebook/TextLayoutBuilder/pull/35\n\nX-link: https://github.com/facebook/SoLoader/pull/122\n\nallow-large-files\n\nThis diff migrates google java format form 1.7 to 1.21.0. This update will allow for new language features from java 17 and 21. This diff also formats all necessary files.\n\n Changelog:\n [Internal][Changed] - Updated format from google-java-format 1.7 -> 1.21.0\n\nReviewed By: IanChilds\n\nDifferential Revision: D52786052\n\nfbshipit-source-id: b675ae215084f340b93dfe628e329e696ca0616e","shortMessageHtmlLink":"Migrate google java format from 1.7 -> 1.21.0 (#324)"}},{"before":"9a293724ce6da2a14df462befa6ef8ae6c7b98c2","after":"03124ba42658fee5581e713a49a388bece8cdf98","ref":"refs/heads/main","pushedAt":"2024-03-03T01:45:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"apply Black 2024 style in fbandroid (2/16)\n\nSummary:\nFormats the covered files with pyfmt.\n\npaintitblack\n\nReviewed By: aleivag\n\nDifferential Revision: D54447731\n\nfbshipit-source-id: 1307eb87c70e2fcc92e4a7441b53de3a69a85bc5","shortMessageHtmlLink":"apply Black 2024 style in fbandroid (2/16)"}},{"before":"f4568d4b696fd6f5b48799dc69dbe55ff6e3e641","after":"9a293724ce6da2a14df462befa6ef8ae6c7b98c2","ref":"refs/heads/main","pushedAt":"2024-01-15T14:28:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove debug specific configurations from `ComponentsConfiguration`\n\nSummary:\n## Important\nThis is a \"copy\" of D52563388, which was reverted due to three classes that were still referring to the old configurations and somehow Sandcastle missed. I'm updating those references on top of this copy.\n\n## Original Description\nThis diff removes debug specific configurations from `ComponentsConfiguration` in Litho into a new abstraction named `LithoDebugConfigurations`. The goal is that we move further into having `ComponentsConfiguration` to be more focused in internals/behaviors of Litho.\n\nReviewed By: adityasharat\n\nDifferential Revision: D52779201\n\nfbshipit-source-id: 8f540efbe2691f7b8c22d1b199a14ff02f986c9c","shortMessageHtmlLink":"Remove debug specific configurations from ComponentsConfiguration"}},{"before":"6f7cf3cbbe7f82a3a4c670270d8e5cd09d7db428","after":"f4568d4b696fd6f5b48799dc69dbe55ff6e3e641","ref":"refs/heads/main","pushedAt":"2023-11-14T20:32:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"This image.close crashes (#322)\n\nSummary:\nOn my version of Python/PIL it crashes with:\n\n```\nTraceback (most recent call last):\n File \"\", line 198, in _run_module_as_main\n File \"\", line 88, in _run_code\n File \"/home/arnold/.gradle/caches/jars-9/c0e3396506bdc4bbb1c7955ef2d0f623/plugin-0.15.0.jar/android_screenshot_tests/pull_screenshots.py\", line 721, in \n File \"/home/arnold/.gradle/caches/jars-9/c0e3396506bdc4bbb1c7955ef2d0f623/plugin-0.15.0.jar/android_screenshot_tests/pull_screenshots.py\", line 703, in main\n File \"/home/arnold/.gradle/caches/jars-9/c0e3396506bdc4bbb1c7955ef2d0f623/plugin-0.15.0.jar/android_screenshot_tests/pull_screenshots.py\", line 613, in pull_screenshots\n File \"/home/arnold/.gradle/caches/jars-9/c0e3396506bdc4bbb1c7955ef2d0f623/plugin-0.15.0.jar/android_screenshot_tests/recorder.py\", line 110, in record\n File \"/home/arnold/.gradle/caches/jars-9/c0e3396506bdc4bbb1c7955ef2d0f623/plugin-0.15.0.jar/android_screenshot_tests/recorder.py\", line 80, in _record\n File \"/home/arnold/.gradle/caches/jars-9/c0e3396506bdc4bbb1c7955ef2d0f623/plugin-0.15.0.jar/android_screenshot_tests/recorder.py\", line 66, in _copy\n File \"/usr/lib/python3/dist-packages/PIL/Image.py\", line 566, in __exit__\n self._fp.close()\n ^^^^^^^^^^^^^^\n File \"/usr/lib/python3/dist-packages/PIL/_util.py\", line 19, in __getattr__\n raise self.ex\nValueError: Operation on closed image\n```\n\nThe `with` block should handle the closing.\n\nPull Request resolved: https://github.com/facebook/screenshot-tests-for-android/pull/322\n\nTest Plan: Before applying this change, did `./gradlew :*:publishToMavenLocal` and then ran `./gradlew :sample:recordDebugAndroidTestScreenshotTests`. Saw crash. Made changed. Re-ran publishToMavenLocal and the tests again, and it passes this time.\n\nDifferential Revision: D51312408\n\nPulled By: xiphirx\n\nfbshipit-source-id: bd5743806a9624cc10f82e017a9568c41848d0c4","shortMessageHtmlLink":"This image.close crashes (#322)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEHaTCtgA","startCursor":null,"endCursor":null}},"title":"Activity ยท facebook/screenshot-tests-for-android"}