Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okhttp3 support #327

Closed
AAverin opened this issue Jan 10, 2016 · 6 comments

Comments

@AAverin
Copy link

commented Jan 10, 2016

New version of okhttp have changed the way interceptors are added to the client.
When can we expect stetho update to support okhttp3?

@felipecsl

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2016

This is being tracked by #324

@kamilwlf

This comment has been minimized.

Copy link

commented Jan 14, 2016

When you plan to fix it?

OkHttpClient okClient = new OkHttpClient.Builder()
.addNetworkInterceptor((Interceptor) new StethoInterceptor())
.build();

Caused by: java.lang.ClassCastException: com.facebook.stetho.okhttp.StethoInterceptor cannot be cast to okhttp3.Interceptor

I use compile 'com.squareup.okhttp3:okhttp:3.0.0-RC1'

@panzerdev

This comment has been minimized.

Copy link

commented Jan 14, 2016

This would really be an Important change! Also OkHttp 3.0 is final as of today.

@jakewilson801

This comment has been minimized.

Copy link

commented Jan 14, 2016

I totally agree with @panzerdev I'm dying to have this working with OkHttp3.0

@jasta

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2016

Sorry folks, I was asleep at the wheel on this and will be cutting a release tomorrow to address this. A new module will be added, stetho-okhttp3 which will replace the current stetho-okhttp.

@jasta

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2016

#324 is now closed, the milestone (https://github.com/facebook/stetho/milestones/1.3.0) now tracks the release.

@jasta jasta closed this Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.