Skip to content

Remove ThriftClientManagerProvider #60

Closed
wants to merge 1 commit into from
Commits on Feb 8, 2013
  1. @andrewcox

    Remove ThriftClientManagerProvider

    andrewcox committed Feb 8, 2013
    Creating the ThriftClientManager through a provider makes it harder for Guice life cycle managemers to close() the manager in a @PreDestroy method. The only reason it was there was to enable passing a non-default maxFrameSize.
    
    This change makes maxFrameSize a per-client configuration parameter, and binds ThriftClientManager directly (not through a provider).
Something went wrong with that request. Please try again.