TTPostController: moves calls to super controller's view appear/disappear methods#442
TTPostController: moves calls to super controller's view appear/disappear methods#442echamberlain wants to merge 1 commit into
Conversation
|
Currently testing it, replaced previous pull by this one, I'm submitting an app to Apple today with this... |
|
Tested and confirmed that this works. Can you squash your commits into one and force push back to this branch? Also, for the commit message, please prefix it with Thanks for putting this together! |
|
Done. |
|
And one last request for the commit message: we should try to make it more descriptive to the task. Something like And then in the body of the commit, if you could add a simple description of the problem as it existed before this change and how this change fixes it, we'll be gold to merge this in. Pardon the pickiness here, but this is one of those changes that might not be particularly obvious in the future if we don't better document the rationale. |
… super controller when displayed. This fix adds a call to the super view controller's viewDidDisappear: after the animation stops. This commit also changes when the super view controller's viewWillAppear: method is called, viewWillAppear: is now called before any animation starts and the super view controller's viewDidAppear: method is now called after the animation stops.
|
By your command. |
|
Cool, thanks :) |
|
Merge branch 'TTPostControllerFix' of https://github.com/echamberlain/three20 into development Closed by 219417e. |
3 participants
Simplified replacement for pull request #436.
This pull request adds a call to the super view controller's viewDidDisappear: after the animation stops.
This request also changes when the super view controller's viewWillAppear: method is called, viewWillAppear: is now called before any animation starts and the super view controller's viewDidAppear: method is now called after the animation stops.