From 5535a29f3bf500a9f00326c1e7c54234f79104a6 Mon Sep 17 00:00:00 2001 From: Xavier Deguillard Date: Thu, 1 Jul 2021 09:12:13 -0700 Subject: [PATCH] win: add --return-nonzero-on-failures to sc_testpilot Summary: For whatever reason, sc_testpilot default to --return-zero-on-failures, which means that test failures are simply not reported properly to the signal box. Fix that by explicitely passing --return-nonzero-on-failures Reviewed By: fanzeyi Differential Revision: D29509158 fbshipit-source-id: ef991f91df48e99769f96ffd8d7015cdf507c723 --- build/fbcode_builder/getdeps/builder.py | 1 + 1 file changed, 1 insertion(+) diff --git a/build/fbcode_builder/getdeps/builder.py b/build/fbcode_builder/getdeps/builder.py index addddea05991..4e523c2dca4f 100644 --- a/build/fbcode_builder/getdeps/builder.py +++ b/build/fbcode_builder/getdeps/builder.py @@ -741,6 +741,7 @@ def list_tests(): "--test-config", "platform=%s" % machine_suffix, "buildsystem=getdeps", + "--return-nonzero-on-failures", ] else: testpilot_args = [