Please sign in to comment.
Update fastpath to catch opening tags.
Summary: If you have something like: $foo = <div>Her's</div>; The fastpath won't pick up the XHP because it thinks it's inside of a string, and it only looks for closing tags, not opening tags. I added an expression to detect opening tags as well, which in practice won't have many false positives. Test Plan: New unit test. Also ran xhpize on FB sources and no new fastpath false positives were introduced. Reviewed By: epriestley
- Loading branch information...
Showing with 10 additions and 0 deletions.
|@@ -0,0 +1,9 @@|
|+$foo = xhp_preprocess_code('<?php|
|+$foo = <div>Her\'s</div>;foo(\'\');');|