Skip to content
This repository

Sep 29, 2009

  1. Marcel Laverdet

    Fix HEREDOC bug

    Heredocs weren't scanning properly in XHP 1.2.1. This fixes that
    Test Plan:
    $foo = <<<HERE
    Reviewed By: epriestley
    Revert: OK
    authored September 29, 2009
  2. Marcel Laverdet

    Bug fixes

    - Line numbers got messed if you closed PHP via "?>"
    - Various parse errors while using "element" as an identifier (Mediawiki)
    Test Plan:
    find ~/tfb/ | grep -E 'phpt?$' | xargs ./xhpize -d -i
    Reviewed By: epriestley
    Revert: OK
    authored September 29, 2009

Sep 26, 2009

  1. Marcel Laverdet

    Making trunk 1.2.0 in ext.hpp

    authored September 25, 2009

Sep 20, 2009

  1. Marcel Laverdet

    Docblock comments and better line numbers

    Summary: Use of yymore() was messing up line numbers in XHP. This also
             introduces preservation of docblock comments by sticking them on as
             a code_rope to the next token encountered.
    Reviewed By: epriestley
    Test Plan: Cursory testing of lite. Test cases in xhpize.
    Revert: OK
    DiffCamp Revision: 65029
    authored September 20, 2009

Sep 19, 2009

  1. Marcel Laverdet

    Complete rewrite; version 1.1.0

    Summary: I deleted most of XHP and started over. Points of interest:
             - Compatibility with at least PHP 5.3, likely up to PHP 6.0.
             - Uses PHP's parser instead the one I wrote
             - Rewritten scanner. The scanner now returns code_rope's with the
             actual code that was scanned, along with line numbers.
             - Separate the XHP parser and extension code
             - Further improved build process
             - No new features
    Reviewed By: epriestley
    Other Commenters: iproctor
    Test Plan: marcel@dev050 ~/alpaca $ php ./lib/init/script.php 
               marcel@dev050 ~/alpaca
               More testing will be done before committing this to APE.
    Revert: OK
    DiffCamp Revision: 64717
    authored September 18, 2009

Aug 20, 2009

  1. Marcel Laverdet

    Support the reflection API getting docblocks

    Summary: XHP strips comments which means the Reflection API can no longer
             glean whatever information it needs from docblocks. This code
             memoizes docblocks and spits them back out in the rewritten code in
             random locations.
             This doesn't include reflection for class constants and stuff
             because those are hard and nobody probably cares anyway. Also if
             you make a habit of embedding docblocks in between every semantic
             token you will likely get back unexpected results while using XHP.
             Included is a half-hearted unit-test directory which includes my
             reflection test that half passes.
    Reviewed By: epriestley
    Test Plan: See unit-text/reflection.php
               Class properties fail.
               Also this:
                 /** comment7a */ class /** comment7b */ BarClass /** comment7c
               */ extends /** comment7d */ FooClass /** comment7e */ {
               Returns comment7e instead of comment7d. Deal with it.
    Revert: OK
    DiffCamp Revision: 60448
    authored August 19, 2009

Jun 22, 2009

  1. Marcel Laverdet

    Quick checkin

    Summary: I just want a checkin of this somewhere that's not my dev server.
    Test Plan: None
    authored June 22, 2009
Something went wrong with that request. Please try again.