New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix riscv. #1103

Merged
merged 1 commit into from Apr 9, 2018

Conversation

Projects
None yet
4 participants
@kilobyte
Contributor

kilobyte commented Apr 8, 2018

On riscv64, 4- and 8-byte accesses are atomic, 1- and 2-byte need library support (-latomic). This is usually automatically added by -pthread, but pzstd said -lpthread instead.

Use -pthread rather than -lpthread.
It can have other effects, such as pulling in extra libraries.  Without it,
riscv build fails with undefined reference to `__atomic_compare_exchange_1'.
@terrelln

Thanks!

@Cyan4973 Cyan4973 merged commit 77e373b into facebook:dev Apr 9, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment