Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the build reproducible #1120

Conversation

lamby
Copy link
Contributor

@lamby lamby commented May 4, 2018

Whilst working on the Reproducible Builds effort [0], we noticed
that zstd could not be built reproducibly.

This is due to the manual page encoding the number of CPUs from the
build machine and thus varies across builds.

This was originally filed in Debian as #897904 [1].

[0] https://reproducible-builds.org/
[1] https://bugs.debian.org/897904

Signed-off-by: Chris Lamb lamby@debian.org

Whilst working on the Reproducible Builds effort [0], we noticed
that zstd could not be built reproducibly.

This is due to the manual page encoding the number of CPUs from the
build machine and thus varies across builds.

This was originally filed in Debian as #897904 [1].

 [0] https://reproducible-builds.org/
 [1] https://bugs.debian.org/897904

Signed-off-by: Chris Lamb <lamby@debian.org>
@Cyan4973
Copy link
Contributor

Cyan4973 commented May 4, 2018

cc @terrelln, since it actually concerns contrib/pzstd

@Cyan4973 Cyan4973 merged commit ef1abd3 into facebook:dev May 4, 2018
@lamby lamby deleted the 897904-libzstd-please-make-the-build-reproducible branch May 5, 2018 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants