Handle cover dictionary builder maximum input size for 32-bit mode #509

Merged
merged 3 commits into from Jan 10, 2017

Projects

None yet

3 participants

@terrelln
Contributor
  • The cover algorithm requires a single buffer of 4x the input size, so in 32-bit mode, the maximum input size is 1 GB.
  • Document the memory requirements for the cover dictionary builder.
  • Make error messages on OOM or too large input clearer.
terrelln added some commits Jan 10, 2017
@terrelln terrelln Use COVER_MEMMULT when training with COVER. c220d4c
@terrelln terrelln Handle large input size in 32-bit mode correctly 555e281
@terrelln terrelln Document memory requirements for COVER algorithm
8d98469
@Cyan4973
Collaborator

All good !

@Cyan4973 Cyan4973 merged commit b8cdc16 into facebook:dev Jan 10, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment