This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Propagate ASCellNode's clipsToBounds value to the __ASTableViewCell #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…This helps work around a bug we are seeing in some rare cases (selected background view overlaps other cells if size of ASCellNode has changed.)
Contributor
|
Thanks @eanagel! I think this is a safe workaround in the short term for this unusual issue, which I'll dig into with priority after the most important ASDataController & layout architecture changes have landed smoothly. |
appleguy
added a commit
that referenced
this pull request
Jul 2, 2015
Propagate ASCellNode's clipsToBounds value to the __ASTableViewCell
fruitcoder
pushed a commit
to digitalegarage/AsyncDisplayKit
that referenced
this pull request
Sep 6, 2017
…xtNodeDelegate (facebookarchive#535) * SEP-491 prerequisite: add textViewShouldBeginEditing: to ASEditableTextNodeDelegate * - added entry to CHANGELOG.md, addressed nit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps work around a bug we are seeing in some rare cases (selected background view overlaps other cells if size of ASCellNode has changed.)
There is an edge case I ignored for this PR - if you set ASCellNode clipsToBounds while the cell is currently visible it will not propagate to the Cell until it is next displayed. (Just because it doesn't seem worth the added complexity.)
@appleguy I've tested this with my ADKFlicker test and my internal project and it masks the issue in both cases.