From 7d2896e9453b034ff69f777d594c91836c8c25f8 Mon Sep 17 00:00:00 2001 From: Marek Cirkos Date: Mon, 27 Mar 2017 10:14:21 -0700 Subject: [PATCH] Fix landscape hitpoint checking Summary: It appears that hitpoint is also not transformed in repsect to window's orientation so we can compare it directly with App's frame Reviewed By: lawrencelomax Differential Revision: D4779067 fbshipit-source-id: 80caa273c24025b9eddcbfd9f3e7008707e00a78 --- WebDriverAgentLib/Categories/XCUIElement+FBIsVisible.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WebDriverAgentLib/Categories/XCUIElement+FBIsVisible.m b/WebDriverAgentLib/Categories/XCUIElement+FBIsVisible.m index ef2a370fd..0cecacb88 100644 --- a/WebDriverAgentLib/Categories/XCUIElement+FBIsVisible.m +++ b/WebDriverAgentLib/Categories/XCUIElement+FBIsVisible.m @@ -43,7 +43,7 @@ - (BOOL)fb_isVisible CGSize screenSize = FBAdjustDimensionsForApplication(app.frame.size, (UIInterfaceOrientation)[XCUIDevice sharedDevice].orientation); CGRect screenFrame = CGRectMake(0, 0, screenSize.width, screenSize.height); BOOL rectIntersects = CGRectIntersectsRect(self.visibleFrame, screenFrame); - BOOL isActionable = CGRectContainsPoint(screenFrame, self.hitPoint); + BOOL isActionable = CGRectContainsPoint(app.frame, self.hitPoint); return rectIntersects && isActionable; }