Permalink
Switch branches/tags
Nothing to show
Commits on May 21, 2010
  1. Choose larger default and min width when action="recommend"

    Summary:
    Title says it all.  We're seeing some clipping of the
    small button when action is set to button_count and action is
    set to recomment.  90 pixels is just too short for Recommend.
    This doesn't address internationalization issues at all, but
    the client also has the ability to specify the width when typing
    out <iframe.. or <fb:like...
    
    Test Plan:
    Loaded www.jerrycain.com/Z100.html (directed at my
    sandbox) and confirmed the iframe widths were what I wanted them
    to be.
    
    DiffCamp Revision: 116910
    Reviewed By: naitik
    Commenters: cat
    CC: cat, naitik, zhen
    Revert Plan:
    OK
    jcain committed May 21, 2010
Commits on May 16, 2010
  1. indicate fbconnect and extern correctly

    Summary:
    Required for http://tools.intern.facebook.com/D111875
    
    Test Plan:
    Look at the other diff.
    
    DiffCamp Revision: 111878
    Reviewed By: brent
    CC: platform-diffs@lists, lshepard, brent, mattwkelly, selekman
    Revert Plan:
    OK
    daaku committed May 6, 2010
Commits on May 15, 2010
  1. Add iframe resizing to connect-js library

    Summary:
    Uses the newly created /connect/canvas_proxy.php to send
    messages to the canvas that we are inside. The first use of these
    messages is setSize so the internal iframe can tell the external page
    what size it wants to be
    
    Test Plan:
    Created a test iframe app. Called both FB.Canvas.setSize() and
    FB.Canvas.startTimerToSizeToContent() and saw it grow to the right size.
    FBML apps aren't affected. Smart-resizing apps work as well (since I
    disable smart resizing when the other end calls setSize()).
    
    Tested on Chrome 5 + Firefox 3.5 on OSX.
    
    Test app here: http://apps.ptarjan.dev229.facebook.com/paul_app_test/resize
    
    DiffCamp Revision: 113392
    Reviewed By: naitik
    Commenters: mathewsb
    CC: ptarjan, lshepard, brent, mathewsb, naitik, mattwkelly, selekman
    Tasks:
    
    Revert Plan:
    OK
    ptarjan committed with daaku May 11, 2010
Commits on May 14, 2010
  1. handle existing query strings

    Test Plan:
    http://www.naitik.dev575.snc1.facebook.com/fbconnect/tests/index.html?initialize&api&query%20string
    
    DiffCamp Revision: 113930
    Reviewed By: abanker
    Commenters: ptarjan
    CC: platform-diffs@lists, ptarjan, lshepard, brent, naitik, abanker,
    mattwkelly, selekman
    Revert Plan:
    OK
    daaku committed May 13, 2010
  2. luke changed his name

    Test Plan:
    http://www.naitik.dev575.snc1.facebook.com/fbconnect/tests/index.html?xfbmltags%20module%3A%20fb%3Aprofile-pic
    
    DiffCamp Revision: 113957
    Reviewed By: lshepard
    CC: platform-diffs@lists, lshepard
    Revert Plan:
    OK
    daaku committed May 13, 2010
  3. remove broken/dead loader/component code

    Test Plan:
    Ran the test suite.
    
    DiffCamp Revision: 113954
    Reviewed By: alpjor
    CC: platform-diffs@lists, lshepard, brent, mattwkelly, alpjor, selekman
    Revert Plan:
    OK
    daaku committed May 13, 2010
  4. Default options to empty {}

    Summary:
    API Key is not longer required.
    
    Test Plan:
    http://www.naitik.dev575.snc1.facebook.com/fbconnect/tests/index.html?initialize&api
    
    DiffCamp Revision: 113927
    Reviewed By: alpjor
    CC: platform-diffs@lists, lshepard, brent, mattwkelly, alpjor, selekman
    Revert Plan:
    OK
    daaku committed May 13, 2010
Commits on May 13, 2010
  1. [joey] make joey use total_count, as we do in sharepro

    Summary:
    it's currently using share_count
    
    Test Plan:
    http://fbrell.com/?server=www.rhe.devrs006
    <fb:like
    href="http://www.rottentomatoes.com/m/sherlock_holmes_2009/"></fb:like>
    <fb:share-button href="http://www.rottentomatoes.com/m/sherlock_holmes_2009/"
    type="button_count"></fb:share-button>
    
    Confirmed joey matches sharepro numbers.
    
    DiffCamp Revision: 113992
    Reviewed By: naitik
    CC: platform-diffs@lists, ahaugen, naitik
    Revert Plan:
    ok
    rhe committed May 13, 2010
  2. format=json-strings to handle 64 bit ints

    Test Plan:
    http://fbrell.com/fb.api/friends has ints.
    http://fbrell.com/fb.api/friends?server=sb has strings.
    
    DiffCamp Revision: 113511
    Reviewed By: rhe
    CC: platform-diffs@lists, lshepard, brent, mattwkelly, selekman
    Revert Plan:
    OK
    daaku committed May 12, 2010
Commits on May 10, 2010
  1. fix typoo

    Test Plan:
    No error on http://fbrell.com/?server=sb anymore.
    
    DiffCamp Revision: 112844
    Reviewed By: wzhu
    CC: platform-diffs@lists, lshepard, brent, mattwkelly, wzhu, selekman
    Revert Plan:
    OK
    daaku committed May 10, 2010
Commits on May 7, 2010
  1. Custom XD Fragment and cleanup

    Summary:
    CNN & Amazon are asking for a custom XD Fragment URL. Generally, there
    is one case where the Fragment transport fails -- when there is
    background audio/video on the page, loading it in the iframe can cause
    it to be play over there as well resulting in double audio streams
    (video part would be hidden).
    
    I've given postMessage the highest priority, but a custom channelUrl
    will be prefered over Flash, where as without a custom channelUrl, we'll
    still prefer Flash to reusing the current page.
    
    I've also explicitly not documented the param in FB.init() for now, as I
    think it will be confusing.
    
    The channel file itself just needs to contain this line:
    
      <script src="http://connect.facebook.net/en_US/all.js"></script>
    
    We could also suggest this URL instead, which results in a much smaller
    JS file, but I'm not going to because the one above should already be
    cached:
    
      http://connect.facebook.net/en_US/xd.js
    
    Test Plan:
    Working on adding tests..
    
    DiffCamp Revision: 112249
    Reviewed By: wzhu
    CC: platform-diffs@lists, lshepard, brent, mattwkelly, wzhu, selekman
    Tasks:
    
    Revert Plan:
    OK
    daaku committed May 7, 2010
  2. Don't animate Connect Bar after the first call

    Test Plan:
    tested in my sandbox.
    http://alpjor.com/test2.html
    
    verified that animation only happens on the first call.
    
    DiffCamp Revision: 109794
    Reviewed By: naitik
    CC: ahaugen, naitik
    Tasks:
    #198934
    #200432
    
    Revert Plan:
    OK
    alpjor committed Apr 28, 2010
  3. Add api-read support to joey.

    Summary:
    We only list a small number of calls in a micro-optimization to keep
    transmission size down (though I didn't actually measure this).
    
    Test Plan:
    test page that makes an api call in the whitelist and not in the
    whitelist; still works, and see that it hits the right endpoint in each
    case.  UTs, but they only touch this obliquely (i.e., you can see that they
    now hit api-read for the non-graph endpoints).
    
    DiffCamp Revision: 107997
    Reviewed By: naitik
    Commenters: brent
    CC: arudolph, lshepard, brent, naitik, mattwkelly, selekman
    Revert Plan:
    Ok
    Arthur Rudolph committed May 4, 2010
Commits on May 3, 2010
  1. remove old api cruft

    Summary:
    no actual code change. just moved api_graph.js to api.js. this is
    already what production is doing. this will also make the generated docs
    accurate
    
    Test Plan:
    http://fbrell.com/fb.api/graph-me?server=sb
    
    DiffCamp Revision: 108445
    Reviewed By: lshepard
    CC: platform-diffs@lists, lshepard, brent, mattwkelly, selekman
    Revert Plan:
    OK
    daaku committed Apr 22, 2010
Commits on Apr 30, 2010
  1. New Live Stream Box: Add post to profile setting to JS

    Summary:
    Adding this setting to the XFBML tag
    
    Task ID: #
    
    Blame Rev:
    
    Reviewed By: naitik
    
    CC:
    
    Test Plan:
    1. Confirm that changing the setting in the XFBML tag changes the
    behaviour in the iframe
    
    Revert Plan:
    
    Tags:
    
    DiffCamp Revision: 109785
    twhitnah committed with daaku Apr 30, 2010
Commits on Apr 27, 2010
  1. Better Top Margin detection for Connect Bar

    Summary:
    This corrects a bug that yelp reported where the connect bar wasn't animating
    the page topMargin far enough. This diff adds better top margin detection to
    browsers that support it (non ie7, ie6).
    
    Test Plan:
    tested in my sandbox with all browsers
    http://alpjor.com/test2.html
    
    DiffCamp Revision: 109482
    Reviewed By: naitik
    CC: ahaugen, naitik
    Tasks:
    #198934
    
    Revert Plan:
    OK
    alpjor committed Apr 27, 2010
  2. auto resize

    Test Plan:
    None.
    
    DiffCamp Revision: 109312
    Reviewed By: julie
    CC: platform-diffs@lists, julie
    Revert Plan:
    OK
    daaku committed Apr 27, 2010
Commits on Apr 26, 2010
  1. Fix Links in connect bar in Safari

    Summary:
    Safari seems to fail in following outbound links in the connect bar unless the
    user has clicked another element in the page. This works around the behavior
    
    Test Plan:
    Tested in my sandbox:
    http://alpjor.com/test2.html
    
    in all browsers
    
    DiffCamp Revision: 109139
    Reviewed By: naitik
    CC: mvernal, ahaugen, naitik
    Tasks:
    #198934
    
    Revert Plan:
    OK
    alpjor committed Apr 26, 2010
  2. Remove the logo from the connect bar

    Summary:
    people want to try text now.
    
    Test Plan:
    tested in my sandbox:
    http://alpjor.com/test2.html
    
    DiffCamp Revision: 109078
    Reviewed By: naitik
    CC: mvernal, ahaugen, naitik
    Tasks:
    #198480
    
    Revert Plan:
    OK
    alpjor committed Apr 26, 2010
Commits on Apr 25, 2010
  1. fix double iframe reload

    Test Plan:
    Charles to redirect JS SDK to sanbox and tested here:
    http://developers.facebook.com/docs/reference/plugins/login
    
    DiffCamp Revision: 108959
    Reviewed By: mvernal
    CC: platform-diffs@lists, mvernal
    Tasks:
    #199154
    
    Revert Plan:
    OK
    daaku committed Apr 25, 2010
Commits on Apr 23, 2010
  1. Live Stream Box: Change JS to point to renamed live_stream_box

    Summary:
    I'm renaming live_feed.php to live_stream_box.php. live_feed.php
    is not currently used in production.
    
    Test Plan:
    1. Confirm connect widget when configured with redesign option
       goes to plugins/live_stream_box.php
    
    DiffCamp Revision: 108634
    Reviewed By: naitik
    CC: naitik
    Revert Plan:
    OK
    twhitnah committed Apr 23, 2010
Commits on Apr 21, 2010
  1. fix IE limit on number of styles

    Summary:
    IE can only create 31 style nodes using createStyleSheet.
    The work around is to add the rules one by one into an
    existing style element.
    
    Test Plan:
    in a page, in IE create 31 styles using
    document.createStyle();
    
    put a <fb:like></fb:like>
    
    Then initialise our lib and make sure the comment box
    is properly styled.
    
    DiffCamp Revision: 108172
    Reviewed By: naitik
    CC: ngao, naitik
    Tasks:
    #197931
    
    Revert Plan:
    OK
    yohannrichard committed Apr 21, 2010
  2. hover fix for joey

    Test Plan:
    http://fbrell.com/secret/fb:like?server=sb
    
    DiffCamp Revision: 108043
    Reviewed By: julie
    CC: platform-diffs@lists, julie
    Revert Plan:
    OK
    daaku committed Apr 21, 2010
Commits on Apr 20, 2010
  1. make fb:facepile reload itself when the user's connect status has cha…

    …nged
    
    Summary:
    this is just like fb:login works
    
    Test Plan:
    on fbrell.com/?server=www.yariv.dev238, rendered both widgets, logged in,
    logged out, logged back in, and verified their states changed appropriately
    
    DiffCamp Revision: 107881
    Reviewed By: naitik
    CC: naitik, amenghra, yariv
    Revert Plan:
    OK
    yariv committed Apr 20, 2010
  2. [like box] adjust header logic to size correctly

    Summary:
    ATTS
    
    Reviewerers: yariv
    
    Test Plan:
    http://fbrell.com/?server=www.rhe.devrs006
    
    <fb:like-box name="cocacola"></fb:like-box>
    <fb:like-box name="cocacola" header=0></fb:like-box>
    <fb:like-box name="cocacola" stream=0></fb:like-box>
    <fb:like-box name="cocacola" stream=0 header=0></fb:like-box>
    <fb:like-box name="cocacola" connections=0></fb:like-box><fb:like-box
    name="cocacola" stream=0 connections=0></fb:like-
    
    DiffCamp Revision: 107807
    Reviewed By: yariv
    CC: naitik, yariv
    Revert Plan:
    ok
    rhe committed Apr 20, 2010
  3. Set bottom margin to remove padding

    Summary:
    the iframe lines up to its container's baseline
    without a proper vertical-align setting.
    
    Test Plan:
    tested in Chrome, Safari, IE6 to 8, FF
    go to fbrell, try the activity, recommendations and like widget.
    make sure there's no gap between the bottom of the iframes and the
    span container.
    
    DiffCamp Revision: 107578
    Reviewed By: naitik
    CC: ngao, naitik
    Tasks:
    #196217
    
    Revert Plan:
    OK
    yohannrichard committed Apr 20, 2010
  4. Add Learn More URL

    Summary:
    Just got the learn more URL from austin. This adds it to the connect bar. NOTE:
    url is not up yet.
    
    Test Plan:
    tested in my sandbox: verified that correct url is present.
    
    DiffCamp Revision: 107493
    Reviewed By: jcain
    CC: ahaugen, jcain
    Revert Plan:
    OK
    alpjor committed Apr 20, 2010
  5. oauth_token => access_token

    Test Plan:
    http://fbrell.com/auth/session?server=sb&comps=graph
    
    DiffCamp Revision: 107634
    Reviewed By: btaylor
    CC: platform-diffs@lists, btaylor, lshepard, brent, naitik, mattwkelly,
    selekman
    Revert Plan:
    OK
    daaku committed Apr 20, 2010
  6. fb:like shows an iframe with the content 'false'

    Summary:
    Some IE hack to fix a caching bug requires a temp
    iframe with src="javascript:false". In IE this results
    into an iframe actualy containing the word 'false' flashing
    in place of the like button.
    To solve this, make the iframe height to 1px.
    
    Test Plan:
    in ie8 go to http://fbrell.com/secret/fb:like
    and make sure you don't see 'false' words flashing
    in place of the like widgets.
    
    DiffCamp Revision: 107525
    Reviewed By: naitik
    CC: ngao, lshepard, brent, naitik, mattwkelly, selekman
    Tasks:
    #196706
    
    Revert Plan:
    OK
    yohannrichard committed Apr 20, 2010
  7. Fix IE

    Summary:
    
    Task ID: #
    
    Blame Rev:
    
    Reviewed By: julie
    
    CC:
    
    Test Plan: Tested in IE7/IE8
    
    Revert Plan:
    
    Tags:
    
    - begin *PUBLIC* platform impact section -
    Bugzilla: #
    - end platform impact -
    daaku committed Apr 20, 2010
Commits on Apr 19, 2010
  1. Correct capitalization error in insights.js

    Summary:
    _apiKey not _apikey
    
    Test Plan:
    Tested in my sandbox and verified that the api_key is indeed appended to the
    impression logging url
    
    DiffCamp Revision: 107423
    Reviewed By: naitik
    CC: lshepard, brent, naitik, mattwkelly, selekman
    Tasks:
    #189660
    
    Revert Plan:
    OK
    alpjor committed Apr 19, 2010
  2. Make xfbml like button comment widget go over xfbml activity feed widget

    Summary:
    Needs higher z-index on the parent
    
    Originally from Julie:
    http://tools.intern.facebook.com/D107390
    
    Test Plan:
    Put xfbml like above xfbml activity and verified that adding z-index
    made the comment box go above while taking it away made the comment box
    go below: http://www.julie-3.devrs004.facebook.com/testpage_like2.htm
    
    DiffCamp Revision: 107393
    Reviewed By: julie
    CC: platform-diffs@lists, julie
    Revert Plan:
    OK
    daaku committed Apr 19, 2010
  3. create fb:facepile xfbml tag

    Summary:
    this is modeled (i.e. copy and pasted from) after login.js
    
    Test Plan:
    I couldn't get it to work. It complained about dynamic_loader not existing.
    Help?
    
    DiffCamp Revision: 107280
    Reviewed By: naitik
    CC: naitik, amenghra
    Revert Plan:
    OK
    yariv committed Apr 19, 2010
  4. [connect] new library for joey with new tags, and endpoints

    Summary:
    Going forward, we'll only document fb:like-box not fb:fan
    Also made sure other stuff works properly.
    
    Test Plan:
    went into fbrell
    
    <fb:login></fb:login>
    <fb:live-stream></fb:live-stream>
    <fb:activity site="cnn.com"></fb:activity>
    <fb:recommendations site="cnn.com"></fb:recommendations>
    <fb:like-box name="cocacola"></fb:like-box>
    <fb:comments></fb:<fb:like></fb:like>
    <fb:serverfbml fbml="<fb:name uid="></fb:serverfbml>
    
    Also ran naitik's recommmended index.html unit test thingy
    
    DiffCamp Revision: 107200
    Reviewed By: naitik
    CC: platform-diffs@lists, lshepard, brent, naitik, mattwkelly, selekman
    Revert Plan:
    ok
    
    - begin *PUBLIC* platform impact section -
    Updated joey
    - end platform impact -
    rhe committed Apr 18, 2010
  5. Connect Bar JS fix for position support in javascript libraries

    Summary:
    Yelp reported that when they tried to use the connect bar with their site they
    found that absolutely positioned element were offset by the height of the
    connect bar. This was because we were modifying the margin on the HTML tag as a
    hack to get the body background image to move along with the body. In order to
    fix this we needed to be able to animate the backgroundPosition css property and
    that required a rewrite of the animation class.
    
    I also found an instantce where an api callback was null and was firing an
    error that I fixed.
    
    I also fixed the css for the connect bar in ie6 that was busted from an earlier
    commit.
    
    Test Plan:
    Tested in my sandbox:
    http://alpjor.com/test2.html
    
    Tested in all browsers
    Tested the animation library for speed (much faster now)
    
    DiffCamp Revision: 107015
    Reviewed By: naitik
    CC: mvernal, isaac, ahaugen, lshepard, brent, naitik, mattwkelly, alpjor,
    selekman
    Tasks:
    #193035
    #184421
    
    Revert Plan:
    OK
    alpjor committed Apr 18, 2010