Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid PHP notice when the "signed_request" is not well formatted. #11

Closed
wants to merge 1 commit into from

Conversation

@GromNaN
Copy link

@GromNaN GromNaN commented Feb 25, 2012

This is an alternative to #4

When the "signed_request" is modified or empty, a PHP notice is generated in BaseFacebook:: parseSignedRequest().

@GromNaN
Copy link
Author

@GromNaN GromNaN commented Apr 23, 2012

I've accepted the CLA, can you review this PR ?

@gfosco
Copy link
Contributor

@gfosco gfosco commented Oct 15, 2013

Sorry it took this long to respond to this. At this time, there are merge conflicts, and I have a question: Is there a better or more comprehensive way to validate the signed_request? What are the scenarios where signed_request is modified or empty causing it to log a notice? If you want to update the PR and re-open this, we can look into this further. Thanks for your contribution.

@gfosco gfosco closed this Oct 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.