Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Ease the walking over the paginated urls by also allowing full-facebook ... #26

Closed
wants to merge 1 commit into from

2 participants

@jappievw

...url's to the api method.

@gfosco
Collaborator

Sorry it took so long to respond to this. Can you sign the Contributor License Agreement? https://developers.facebook.com/opensource/cla

Once that's done we can look at this further. I'm concerned that using the hardcoded URL may not be the best solution, but it can be discussed. Thanks for your contribution.

@jappievw

@gfosco just signed the CLA.

@gfosco
Collaborator

I spoke too quick. We discussed this internally and at this time we do not want to add this to the core SDK.

@gfosco gfosco closed this
@jappievw

@gfosco Ok clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 16, 2012
  1. @jappievw

    Ease the walking over the paginated urls by also allowing full-facebo…

    jappievw authored
    …ok url's to the api method.
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 0 deletions.
  1. +3 −0  src/base_facebook.php
View
3  src/base_facebook.php
@@ -1018,6 +1018,9 @@ protected function getUrl($name, $path='', $params=array()) {
if ($path[0] === '/') {
$path = substr($path, 1);
}
+ else if (substr($path, 0, 8) === 'https://') {
+ $path = preg_replace('/^https:\/\/[a-z-]*\.facebook\.com\//', '', $path);
+ }
$url .= $path;
}
if ($params) {
Something went wrong with that request. Please try again.