removed exception catching #40

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

requests failed silently without giving a reason before

removed exception catching
requests failed silently without giving a reason before
Contributor

gfosco commented Oct 10, 2013

Sorry this was not responded to sooner. At this time there are merge conflicts, and I really do not think we want to remove exception handling from the SDK. If there is still a valid reason for changing this, please update and open a new request. Thanks for your input.

@gfosco gfosco closed this Oct 10, 2013

A pity, it means that a user of the FB API cannot see the error which occurred since that is hidden in the FacebookApiException, which is never communicated outside of those functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment