Use `empty()` for signed request value check #45

Merged
merged 1 commit into from Dec 11, 2012

Projects

None yet

2 participants

@favrik
favrik commented Nov 28, 2012

Use !empty(...) instead of isset(...) to check the signed request value inside the getSignedRequest() method. This avoids trying to parse an empty signed request, and removes the not very accurate "Unknown algorithm. Expected HMAC-SHA256." error from the logs. :)

See: http://stackoverflow.com/questions/13535474/unknown-algorithm-expected-hmac-sha256-error-due-to-signed-request-cookie-bein

@oyvindkinsey oyvindkinsey merged commit 1899bf9 into facebookarchive:master Dec 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment