Session Checking & Readme #55

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Dec 19, 2012

When having a session_start() in your own code the session_start() in facebook.php would fire again, which would result in sending the headers again. This gives warnings in the logs, this code fixes the if statement.

I also updated the readme file, it says 'require' which could better be changed to require_once to prevent multiple inclusions. It's small detail however..

Swen Kooij and others added some commits Dec 19, 2012

Swen Kooij
Fixed checking for active session
It was broken and did not work.
Added useragent to config array in the construtor
You can now specify a custom useragent in the $config array in the constructor.
Updated readme.md
It's recommend to use require_once instead of require. To prevent
multiple inclusions.
@gfosco

This comment has been minimized.

Show comment Hide comment
@gfosco

gfosco Oct 14, 2013

Contributor

Sorry it took this long to respond to this. We're tracking several issues to be corrected soon, many of which include the CURL options. I'm going to close this and it will be addressed along with some other issues in a future commit. Related PRs: 16, 18, 36, 52, and we'll look into the session_start issue as well. Thanks for your feedback.

Contributor

gfosco commented Oct 14, 2013

Sorry it took this long to respond to this. We're tracking several issues to be corrected soon, many of which include the CURL options. I'm going to close this and it will be addressed along with some other issues in a future commit. Related PRs: 16, 18, 36, 52, and we'll look into the session_start issue as well. Thanks for your feedback.

@gfosco gfosco closed this Oct 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment