Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Implement column reordering #361

Closed
wants to merge 9 commits into from
Closed

Conversation

stutrek
Copy link

@stutrek stutrek commented Mar 3, 2016

This adds support for drag and drop column reordering, adds and example, and updates the docs. It is used just like column resizing, with a onColumnReorderEndCallback passed as a prop to the table.

note: I am ignoring the directive not to edit the dist folder because I actually need to use this.

If you're trying to use this you can include it the normal npm way and add this to your webpack config:

  alias: {
    'fixed-data-table$': __dirname + '/node_modules/fixed-data-table/dist/fixed-data-table'
  }

@stutrek stutrek changed the title Add column reordering Implement column reordering Mar 3, 2016
tchoiSchrodinger added a commit to schrodinger/fixed-data-table-2 that referenced this pull request Apr 11, 2016
@ghost ghost added the CLA Signed label Jul 12, 2016
@JMacLulich
Copy link

This is great, thanks @stutrek exactly what I was looking for, is there any chance this PR can make it into master?

@ghost ghost added the CLA Signed label Jul 26, 2016
@stutrek
Copy link
Author

stutrek commented Jul 26, 2016

@JMacLulich I think you're going to want this branch, it's much better. I haven't had time to close this PR and make a new one yet.

https://github.com/stutrek/fixed-data-table/tree/f/better-reorder

@ghost ghost added the CLA Signed label Jul 26, 2016
@KamranAsif
Copy link

@wcjordan can we get a ticket to bring over these commits?

@stutrek
Copy link
Author

stutrek commented Jul 26, 2016

I just rebased

@ghost ghost added the CLA Signed label Jul 26, 2016
@zpao
Copy link
Contributor

zpao commented Oct 27, 2017

Thanks for your pull request. I apologize for leaving this project in limbo and not addressing your concerns. I have archived this project after doing a final release to make it compatible with React v16.

@zpao zpao closed this Oct 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants