create Apache Giraph-compatible facebook jars. #11

Open
wants to merge 1 commit into
from

Projects

None yet

4 participants

@ekoontz
ekoontz commented Jun 29, 2012

Giraph (http://giraph.apache.org)'s facebook profile has the following:

<dependency>
      <groupId>com.facebook.hadoop</groupId>
      <artifactId>hadoop-core</artifactId>
      <version>0.20.1</version>
      <type>jar</type>
      <scope>system</scope>
      <systemPath>${hadoop.jar.path}</systemPath>
</dependency>

However Facebook's build.xml and copy-hdfs-jars-to-maven.sh do not conform to this.

@aching aching was assigned Jun 29, 2012
@weiyanwang
Contributor

@aching could you take a look? I am not familiar with giraph. Thanks!

@aching
Contributor
aching commented Jul 2, 2012

Eugene, thanks for looking into this. I think the dependency should rather be org.apache.hadoop instea od com.facebook.hadoop. My bad.

@nitay
nitay commented Oct 20, 2012

@aching can we revisit this? I disagree with you, I think the groupId should definitely be com.facebook.hadoop as @ekoontz has it. In fact if you look at the main maven repo there are a few groups that publish hadoop jars (http://search.maven.org/#search%7Cga%7C1%7Chadoop-core). That is the whole point of setting the groupId to the company so you know who is providing it.

Anyways, can we get this in? I this we should get the facebook jar published all the way up to maven. See e.g. https://docs.sonatype.org/display/Repository/Sonatype+OSS+Maven+Repository+Usage+Guide. I can take this on this step after we get this diff in. Then the whole hack with user specifying path to jar can be taken out altogether and people will be able to build off of Facebook's hadoop just as easily as any other profile in Giraph.

Thoughts?

@aching
Contributor
aching commented Oct 20, 2012

That seems reasonable. Let me ask around on Monday and see if anyone uses this script.

@aching aching closed this Oct 20, 2012
@aching aching reopened this Oct 20, 2012
@aching aching was unassigned by ekoontz Oct 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment