Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Change Instagram.respond_to? signature #122

Merged
merged 1 commit into from Jun 9, 2014

Conversation

Projects
None yet
5 participants
Contributor

be9 commented Jun 5, 2014

Ruby 1.9 and 2.0 allow Object#respond_to? to receive two arguments:

respond_to?(symbol, include_all=false)

Current signature with only one argument makes trouble when using rspec 3.0 to mock Instagram class behavior.

Change Instagram.respond_to? signature
Ruby 1.9 and 2.0 allow Object#respond_to? to receive two arguments:

respond_to?(symbol, include_all=false)

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

Contributor

be9 commented Jun 5, 2014

Signed up.

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

tagliala commented Jun 5, 2014

@be9 I also ran into this issue: rspec/rspec-rails#1066

Please take a look at the following comment: rspec/rspec-rails#1066 (comment)

Also ran into this issue.
Any chance of merging this fix?

heatonjb added a commit that referenced this pull request Jun 9, 2014

Merge pull request #122 from be9/master
Change Instagram.respond_to? signature

@heatonjb heatonjb merged commit 3c9dd74 into facebookarchive:master Jun 9, 2014

Contributor

heatonjb commented Jun 9, 2014

Merged and released to Ruby Gems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment