Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Stop truncating meaningful data from requests. #41

Merged
merged 2 commits into from Feb 22, 2013

Conversation

Projects
None yet
2 participants
Contributor

yaauie commented Jul 6, 2012

Create a Response object and use it to combine meta and pagination into the response
data instead of truncating it out. This broke the expectations in a variety of places,
but at least it brings the gem's method signature to be consistent with itself across
the board.

Contributor

yaauie commented Feb 21, 2013

Ping?

Contributor

shayne commented Feb 21, 2013

@yaauie mind rebasing?

yaauie added some commits Jul 6, 2012

Create a Response object and use it to combine meta and pagination in…
…to the response

data instead of truncating it out. This broke the expectations in a variety of places,
but at least it brings the gem's method signature to be consistent with itself across
the board.
Contributor

yaauie commented Feb 21, 2013

Done. A (probably unrelated?) spec for Instagram::Client::oembed is failing, but other than that things pass ok.

shayne added a commit that referenced this pull request Feb 22, 2013

Merge pull request #41 from simplymeasured/feature/response-object
Stop truncating meaningful data from requests.

@shayne shayne merged commit 3120089 into facebookarchive:master Feb 22, 2013

Contributor

shayne commented Feb 22, 2013

Fixed the issue, see b27346a.

Contributor

shayne commented Feb 22, 2013

Cut 0.9.1

Contributor

yaauie commented Feb 22, 2013

Since this was an API-breaking change (and the gem is still a 0.X), Semantic Versioning dictates that the minor version should be bumped, not the patch version, leaving the gem at 0.10.x.

Contributor

shayne commented Feb 22, 2013

Thanks. I just pushed another bump so people don't get confused / tripped up.

erinnorr pushed a commit to erinnorr/instagram-ruby-gem that referenced this pull request Feb 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment