Add no_response_wrapper as config option #97

Merged
merged 1 commit into from Apr 3, 2014

Conversation

Projects
None yet
2 participants
Contributor

carmi commented Jan 27, 2014

Add no_response_wrapper as a configuration option when instantiating a
client. Then all requests will use this as the default. Useful if you
want to do pagination or use the other metadata that is not normally
sent back in responses.

I've followed instructions in README for submitting a PR and all specs are passing.

Evan Carmi Add no_response_wrapper as config option
Add no_response_wrapper as a configuration option when instantiating a
client. Then all requests will use this as the default.  Useful if you
want to do pagination or use the other metadata that is not normally
sent back in responses.
fa4940d
Contributor

heatonjb commented Apr 2, 2014

In order to accept your pull request, we need you to submit a CLA. You only need to do this once to work on any of Instagram's or Facebook's open source projects.

Complete your CLA here: https://code.facebook.com/cla

Contributor

carmi commented Apr 2, 2014

I have completed the CLA.

On Wed, Apr 2, 2014 at 7:19 AM, Jonathan Heaton notifications@github.comwrote:

In order to accept your pull request, we need you to submit a CLA. You
only need to do this once to work on any of Instagram's or Facebook's open
source projects.

Complete your CLA here: https://code.facebook.com/cla


Reply to this email directly or view it on GitHubhttps://github.com/Instagram/instagram-ruby-gem/pull/97#issuecomment-39318616
.

Evan H. Carmi
http://ecarmi.org/

Contributor

heatonjb commented Apr 2, 2014

Hey @carmi great diff. But please could you add a spec test that covers this?

Contributor

heatonjb commented Apr 3, 2014

Ideally yes. How about a a test with no-response-wrapper set to false and
check for existence of the wrapper.

@heatonjb heatonjb merged commit fa4940d into facebookarchive:master Apr 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment