Skip to content
This repository has been archived by the owner on Mar 9, 2019. It is now read-only.

Compile Failure #72

Closed
DomT4 opened this issue Nov 13, 2014 · 6 comments
Closed

Compile Failure #72

DomT4 opened this issue Nov 13, 2014 · 6 comments

Comments

@DomT4
Copy link

DomT4 commented Nov 13, 2014

Hey guys,

Libphenom is currently refusing to compile on OS X 10.10, both with Clang and (GNU) gcc.

Here's a gist of the build log.

Using:

OpenSSL 1.0.1j
Concurrencykit 0.4.4
Automake 1.14.1
Autoconf 2.69
GNU Libtool 2.4.2
Pkg-config 0.28

@wez
Copy link
Contributor

wez commented Nov 13, 2014

are you building that from a homebrew recipe?

@wez
Copy link
Contributor

wez commented Nov 13, 2014

Can you include the actual commands that are being used to build this?
cloning and build works fine here.
The error message is that the linter thinks that the include guards don't match; looks like something clever might be going on with the cwd when make is run, but I can't reproduce and resolve the issue without knowing how it is really being invoked.

a workaround is likely make PYTHON=true to cause the linter to appear to pass

@DomT4
Copy link
Author

DomT4 commented Nov 13, 2014

are you building that from a homebrew recipe?

Yeah, one I wrote nonetheless. This one.

Nothing more complicated than git clone && ./autogen.sh && ./configure --prefix=/path/to/dir --disable-dependency-tracking && make && make check && make install.

Nothing weird or unusual.

@DomT4
Copy link
Author

DomT4 commented Nov 13, 2014

The only Homebrew-related differences here are: 1) The OpenSSL directory is preprended to the $PATH because we keep it locked away to avoid conflicting with the OS X native OpenSSL. 2) We use a more modern libtool than Apple ships.

wez added a commit that referenced this issue Nov 13, 2014
The cause of the build failure in #72
is that the brew build checks out the repo without the .git dir.

The linter is looking to make paths relative to the root, and it was
finding the .git dir to determine where the root was.  Without the git
dir being present, it ends up being relative to `/` and fails the build
because the include guards don't match that scheme.

If the .git dir is missing, we'll now just assume that we're being run
from the root, which is the only way that this script is run in
libphenom.
@wez
Copy link
Contributor

wez commented Nov 13, 2014

I pushed a commit to address this. What was happening is that brew was removing the .git dir and that confused the linter about where the root of the repo was. If I copy your formula locally, I can brew install --HEAD libphenom with it (actually, I changed it to only run the lint step as it was quicker, and that was all that I tested)

@DomT4
Copy link
Author

DomT4 commented Nov 13, 2014

Thanks Wez, That did the trick. I'd presume this happens because Homebrew does the git clone element in /Library/Caches/Homebrew but does the building in /tmp, so perhaps the .git directory gets left behind as part of that directory switch. Closing as fixed, Appreciate your time.

@DomT4 DomT4 closed this as completed Nov 13, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants