Curl & Proxies

[stepanselyuk]

In some case the Facebook fix for calculate Curl headers (affected version) in FacebookCurlHttpClient does not fix all cases (according my logs and I got error 601 randomly), so I've changed code of fixing header size:

private function getHeaderSize() {

        $headerSize = self::$facebookCurl->getinfo( CURLINFO_HEADER_SIZE );

        // This corrects a Curl bug where header size does not account
        // for additional Proxy headers.
        if ( self::needsCurlProxyFix() ) {

            if ( preg_match( '/Content-Length: (\d+)/', $this->rawResponse, $m ) ) {

                $headerSize = mb_strlen( $this->rawResponse ) - $m[ 1 ];
            }
            elseif ( stripos( $this->rawResponse, self::CONNECTION_ESTABLISHED ) !== false ) {

                $headerSize += mb_strlen( self::CONNECTION_ESTABLISHED );
            }
        }

        return $headerSize;
}

And that error 601 does not occurred anymore.

[stepanselyuk]

I've found the case:

HTTP/1.0 200 Connection established
Proxy-agent: Kerio Control/7.1.1 build 1971

HTTP/1.1 200 OK
ETag: "5cda087310bbcd784e519292768580d683236e09"
Content-Type: application/json; charset=UTF-8
Pragma: no-cache
Access-Control-Allow-Origin: *
X-FB-Rev: 1272844
Cache-Control: private, no-cache, no-store, must-revalidate
Expires: Sat, 01 Jan 2000 00:00:00 GMT
X-FB-Debug: tHoKhGeGW3vBjkYKlk/zSpKDhDpQXwFIGa3STiCmcPg=
Date: Tue, 03 Jun 2014 09:41:24 GMT
Connection: keep-alive
Content-Length: 228

Detected headers size from Curl: 426
Content-Length: 228
Calculated header size: 510

[SammyK]

+1 for Guzzle! :)

[roman02]

I'd really hate struggling with some random errors on this layer. I keep recalling numerous reports from people about getting zero when calling getUser() using the the old SDK. Such errors are VERY expensive for a business.

[gfosco]

Can you submit a PR for this @stepanselyuk ?

[stepanselyuk]

Ok done #116.