Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly versioning releases with semvar #399

Closed
pugsley opened this issue Apr 15, 2015 · 3 comments
Closed

Correctly versioning releases with semvar #399

pugsley opened this issue Apr 15, 2015 · 3 comments

Comments

@pugsley
Copy link

@pugsley pugsley commented Apr 15, 2015

We've just had a bunch of production failures because this package was upgraded from 4.0.20 > 4.0.23. If you're following semver (http://semver.org/) then that's a patch version to patch version. Patch versions are intended for backwards-compatible bug fixes.

However amongst these patch versions the Facebook Graph endpoint was changed from version 2.2 > 2.3, a massively significant change (085ed43).

IMHO when you bump the Facebook API version you should at least bump the minor version.
e.g. 4.0.20 > 4.1.0.

@pugsley
Copy link
Author

@pugsley pugsley commented Apr 15, 2015

I should mention that this is probably a bit of a grey area because the changes made to this package WERE backwards compatible but the flow on effects of switching to 2.2 > 2.3 broke stuff.

@gfosco
Copy link
Contributor

@gfosco gfosco commented Apr 15, 2015

I wasn't aware going from 2.2 to 2.3 would be considered a BC.. In the future, will take this into account.

Unfortunately, this repo does not follow semver. It was a mistake made when launched. We do have 4.1 in the works, but it's a very large refactoring (see the master branch)..

Thanks.

@gfosco gfosco closed this Apr 15, 2015
@yguedidi
Copy link
Contributor

@yguedidi yguedidi commented Apr 16, 2015

A solution to this would be to use unversionned graph calls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants