Skip to content
This repository was archived by the owner on Jan 13, 2022. It is now read-only.

Fix: Remove unused local variables #592

Merged
merged 1 commit into from
May 21, 2016
Merged

Fix: Remove unused local variables #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions tests/FacebookTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public function testInstantiatingWithoutAppIdThrows()
$config = [
'app_secret' => 'foo_secret',
];
$fb = new Facebook($config);
new Facebook($config);
}

/**
Expand All @@ -104,7 +104,7 @@ public function testInstantiatingWithoutAppSecretThrows()
$config = [
'app_id' => 'foo_id',
];
$fb = new Facebook($config);
new Facebook($config);
}

/**
Expand All @@ -115,7 +115,7 @@ public function testSettingAnInvalidHttpClientHandlerThrows()
$config = array_merge($this->config, [
'http_client_handler' => 'foo_handler',
]);
$fb = new Facebook($config);
new Facebook($config);
}

public function testCurlHttpClientHandlerCanBeForced()
Expand Down Expand Up @@ -165,7 +165,7 @@ public function testSettingAnInvalidPersistentDataHandlerThrows()
$config = array_merge($this->config, [
'persistent_data_handler' => 'foo_handler',
]);
$fb = new Facebook($config);
new Facebook($config);
}

public function testPersistentDataHandlerCanBeForced()
Expand All @@ -191,7 +191,7 @@ public function testSettingAnInvalidUrlHandlerThrows()
$config = array_merge($this->config, [
'url_detection_handler' => 'foo_handler',
]);
$fb = new Facebook($config);
new Facebook($config);
}

public function testTheUrlHandlerWillDefaultToTheFacebookImplementation()
Expand Down Expand Up @@ -302,7 +302,7 @@ public function testSettingAnAccessThatIsNotStringOrAccessTokenThrows()
$config = array_merge($this->config, [
'default_access_token' => 123,
]);
$fb = new Facebook($config);
new Facebook($config);
}

public function testCreatingANewRequestWillDefaultToTheProperConfig()
Expand Down Expand Up @@ -413,6 +413,6 @@ public function testMaxingOutRetriesWillThrow()
'http_client_handler' => $client,
]);
$fb = new Facebook($config);
$response = $fb->uploadVideo('4', __DIR__.'/foo.txt', [], 'foo-token', 3);
$fb->uploadVideo('4', __DIR__.'/foo.txt', [], 'foo-token', 3);
}
}
2 changes: 1 addition & 1 deletion tests/FileUpload/FacebookResumableUploaderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public function testStartWillLetErrorResponsesThrow()
$this->graphApi->failOnStart();
$uploader = new FacebookResumableUploader($this->fbApp, $this->client, 'access_token', 'v2.4');

$chunk = $uploader->start('/me/videos', $this->file);
$uploader->start('/me/videos', $this->file);
}

public function testFailedResumableTransferWillNotThrowAndReturnSameChunk()
Expand Down
2 changes: 1 addition & 1 deletion tests/PersistentData/FacebookSessionPersistentDataHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class FacebookSessionPersistentDataHandlerTest extends \PHPUnit_Framework_TestCa
*/
public function testInactiveSessionsWillThrow()
{
$handler = new FacebookSessionPersistentDataHandler();
new FacebookSessionPersistentDataHandler();
}

public function testCanSetAValue()
Expand Down