Permalink
Browse files

UndefinedFunctionCheck; $_ set even on null; style overhaul

Summary: i should have separated these but i didn't, deal-with-it

UndefinedFunctionCheck has been requested for some time now.

for $_ on null: this behavior seemed wrong:
php> =$a=4
4
php> =$b=null
null
php> =$_
4
but note that now we have:
php> =$a=4
4
php> echo 'hi'
hi
php> =$_
null
i think this is the better trade-off.  no one in their right mind
uses $_ anyway but it's less kooky and more elegant now anyway.

Reviewed By: marcel

Test Plan:
php> =strleng()
Not executing input: Possible call to undefined function strleng()
See /etc/phpsh/config.sample to disable UndefinedFunctionCheck.

but old behavior if ~/.phpsh/config with
[General]
UndefinedFunctionCheck: yes
  • Loading branch information...
Daniel Corson
Daniel Corson committed Dec 2, 2009
1 parent 7d5e8df commit 0fd49c3ee16e00d967c1c42e8015761334e15492
Showing with 326 additions and 242 deletions.
  1. +232 −220 src/__init__.py
  2. +9 −0 src/config.sample
  3. +1 −0 src/phpsh
  4. +84 −22 src/phpsh.php
Oops, something went wrong.

0 comments on commit 0fd49c3

Please sign in to comment.