Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed the Canvas 3d, standard (WebGL) test #54

Merged
merged 1 commit into from Aug 2, 2013

Conversation

Projects
None yet
2 participants
Contributor

phistuck commented Aug 2, 2013

There were multiple issues with the original test -

  • It was trying to create contexts non standard names.
  • The order of the context names to test was reversed (non standard context names would make the browser fail the test, even if it does support the standard context name).

The new test simple tests for the context creation of a context bearing the "webgl" name (which is the standard name).

Desktop Chrome failed this test for no reason. It supports the standard version.

@phistuck phistuck Fixed the Canvas 3d, standard (WebGL) test
There were multiple issues with the original test -
- It was trying to create contexts non standard names.
- The order of the context names to test was reversed (non standard context names would make the browser fail the test, even if it does support the standard context name).

The new test simple tests for the context creation of a context bearing the "webgl" name (which is the standard name).

Desktop Chrome failed this test for no reason. It supports the standard version.
08ba95d
Contributor

rwaldron commented Aug 2, 2013

Copy pasta. Thanks!

@rwaldron rwaldron added a commit that referenced this pull request Aug 2, 2013

@rwaldron rwaldron [rng.io] Fixed the Canvas 3d, standard (WebGL) test (#54
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
cbfaef3

@rwaldron rwaldron merged commit 08ba95d into facebookarchive:master Aug 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment