Fix build on newer platforms (latest Mac OS X, Ubuntu 11.10) #46

Merged
merged 1 commit into from Jan 6, 2012

Projects

None yet

2 participants

@cce
Contributor
cce commented Oct 28, 2011

fix build on systems with Perl > 5.12.0 (Ubuntu 11.10 Oneiric, Mac OS X) due to split() incompatibility

thanks mauke from #perl on freenode!

split() no longer modifies @_ when called in scalar or void context. In void context it now produces a "Useless use of split" warning. This was also a perl 5.12.0 change that missed the perldelta.

from http://perldoc.perl.org/perl5140delta.html

@cce cce fix build on systems with Perl > 5.12.0 (Ubuntu 11.10 Oneiric, Mac OS…
… X) due to split() incompatibility

thanks mauke from #perl on freenode!
from http://perldoc.perl.org/perl5140delta.html
"split() no longer modifies @_ when called in scalar or void context. In void context it now produces a "Useless use of split" warning. This was also a perl 5.12.0 change that missed the perldelta."
32667e1
@groys groys merged commit 63e4824 into facebookarchive:master Jan 6, 2012
@AnnapurnaVemuri AnnapurnaVemuri pushed a commit to AnnapurnaVemuri/scribe that referenced this pull request Mar 14, 2014
@rajubairishetti rajubairishetti Build Failure: No rule to make target `gen-cpp/scribe.cpp', needed by…
… `scribe.o'. Stop.

fix : facebookarchive#46
d8101cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment