Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix build on newer platforms (latest Mac OS X, Ubuntu 11.10) #46

Merged
merged 1 commit into from

2 participants

@cce

fix build on systems with Perl > 5.12.0 (Ubuntu 11.10 Oneiric, Mac OS X) due to split() incompatibility

thanks mauke from #perl on freenode!

split() no longer modifies @_ when called in scalar or void context. In void context it now produces a "Useless use of split" warning. This was also a perl 5.12.0 change that missed the perldelta.

from http://perldoc.perl.org/perl5140delta.html

@cce cce fix build on systems with Perl > 5.12.0 (Ubuntu 11.10 Oneiric, Mac OS…
… X) due to split() incompatibility

thanks mauke from #perl on freenode!
from http://perldoc.perl.org/perl5140delta.html
"split() no longer modifies @_ when called in scalar or void context. In void context it now produces a "Useless use of split" warning. This was also a perl 5.12.0 change that missed the perldelta."
32667e1
@duedal duedal referenced this pull request from a commit
@duedal duedal Compile fixes for Ubuntu 11.10
Combines facebookarchive/scribe#46 and facebook/scribe#36
Also needs this fix: onlinecity/thrift@f15bb6b
67e46e6
@groys groys merged commit 63e4824 into facebookarchive:master
@AnnapurnaVemuri AnnapurnaVemuri referenced this pull request from a commit in AnnapurnaVemuri/scribe
@rajubairishetti rajubairishetti Build Failure: No rule to make target `gen-cpp/scribe.cpp', needed by…
… `scribe.o'. Stop.

fix : facebookarchive#46
d8101cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 28, 2011
  1. @cce

    fix build on systems with Perl > 5.12.0 (Ubuntu 11.10 Oneiric, Mac OS…

    cce authored
    … X) due to split() incompatibility
    
    thanks mauke from #perl on freenode!
    from http://perldoc.perl.org/perl5140delta.html
    "split() no longer modifies @_ when called in scalar or void context. In void context it now produces a "Useless use of split" warning. This was also a perl 5.12.0 change that missed the perldelta."
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  global_header.mk
View
2  global_header.mk
@@ -4,7 +4,7 @@
#endef
define thrift_template
-XTARGET := $(shell perl -e '@val = split("\/","$(2)"); $$last = pop(@val);split("\\.",$$last);print "$(1)/"."gen-cpp/"."@_[0]"."_types.cpp\n"' )
+XTARGET := $(shell perl -e '$$_ = $$ARGV[1]; s{^.*/}{}; s{\..*}{}; print "$$ARGV[0]/gen-cpp/$${_}_types.cpp\n"' '$(1)' '$(2)')
ifneq ($$(XBUILT_SOURCES),)
XBUILT_SOURCES := $$(XBUILT_SOURCES) $$(XTARGET)
Something went wrong with that request. Please try again.