Permalink
Commits on May 16, 2018
Commits on Oct 20, 2016
  1. Allow fallback to plain java namespace if java.swift is missing

    Sergey Makarenko
    Sergey Makarenko committed Oct 19, 2016
    There projects that are not using swift directly so they do not have java.swift namespace in their IDLs.
    And this causes problems for projects that are using swift and including such IDLs indirectly.
    One solution is to modify IDL file and add java.swift namespace which is not always possible or convenient.
    Another approach is to use plain java namespace and generate swift classes using it.
    This change introduces later option adding new boolean tweak configuration option.
    For command line tool it is `fallback_to_java_namespace` and `fallbackToPlainJavaNamespace` for maven plugin.
  2. Add comment with build info into generated code

    Sergey Makarenko
    Sergey Makarenko committed Oct 14, 2016
    Add top line comment which provides the following information about generated file:
    - IDL file location used to generate this file.
    File path is relative to idlFiles:directory parameter for maven-swift-plugin
    and is relative to current directory for cli generator.
    - date when this file was generated
    
    Fixes
  3. Remove unused code

    Sergey Makarenko
    Sergey Makarenko committed Oct 14, 2016
  4. Fix TestSwiftGenerator

    Sergey Makarenko
    Sergey Makarenko committed Oct 13, 2016
    TestSwiftGenerator is a test application that generates swift classes for several test IDLs.
    Those IDLs are located in resources section of the project and there was a previous commit
    that changed location of those test IDL files.
    After that change swift generator could not find included IDLs which is fixed with this change.
Commits on Oct 15, 2016
  1. Fixed code generation for unions with fields whose types are the same…

    tomdz authored and ryantimwilson committed Oct 15, 2016
    … after type erasure (#327)
Commits on Oct 11, 2016
Commits on Oct 10, 2016
Commits on Oct 7, 2016
  1. Revert adding Builder subclasses to unions

    Ryan Wilson
    Ryan Wilson committed Oct 7, 2016
    Using builder subclasses in unions in Swift-generated code causes
    separate errors to be triggered:
    
    Error: Inject method com.facebook.swift.foo is not allowed on struct class, since struct has a builder
    Attempted to resolve a recursive reference to type 'com.facebook.swift.foo' before the referenced type was cached (most likely a recursive type support bug)
  2. Simplify writing TApplicationException to transport

    Sergey Makarenko
    Sergey Makarenko committed Sep 27, 2016
    TNiftyTransport supports setting TApplicaionException. It is possible to get this type
    of transport from instance of NiftyRequestContext. It is possible to isolate this
    check/extraction into function that will use it.
  3. Fix logging of failed method in ThriftServiceProcessor

    Sergey Makarenko
    Sergey Makarenko committed Sep 27, 2016
Commits on Oct 6, 2016
  1. Fix Swift recursive annotation compatiblity with unions

    Ryan Wilson
    Ryan Wilson committed Oct 5, 2016
    Currently, for union fields annotated with recursive = True, Swift generates Java
    code for these fields with Requiredness = None. We should always allow union fields
    to be marked recursive as they are essentially optional.
Commits on Sep 27, 2016
  1. Fix generated Java code for Thrift unions with multiple fields of sam…

    Ryan Wilson
    Ryan Wilson committed Sep 22, 2016
    …e type
    
    Currently, when generating Java code for Thrift unions with multiple fields
    of the same type, the code won't compile. This is because Swift generates
    a constructor per field, so multiple constructors will have the same
    arguments even though they initialize fields differently.
    
    This patch changes the union template to use a builder paradigm in order
    to allow for this case.
Commits on Sep 25, 2016
Commits on Sep 17, 2016
  1. Inject TransportAttachObserver dependency into ThriftServer

    Ryan Wilson
    Ryan Wilson committed Sep 16, 2016
    This allows callers of ThriftServer to specify TransportAttachObserver
    implementations like nifty's SslConfigFileWatcher to watch files for
    changes and update the server configuration when they do.
Commits on Sep 15, 2016
  1. Propagate event handlers' TApplicationExceptions to the client.

    Tomas Vaskevicius
    Tomas Vaskevicius committed Sep 14, 2016
Commits on Sep 8, 2016
  1. Log error if ThriftServiceProcessor failed to handle method.

    Sergey Makarenko
    Sergey Makarenko committed Sep 8, 2016
    Currently if server handler failes to handle request for example due to message serialization
    exception client receives ClosedChannelException and server side logs are silent.
    This is a first step to provide more visibility in case of such errors.
Commits on Aug 29, 2016
  1. Revert "Allow recursive union fields which are not explicitly marked …

    andrewcox committed Aug 29, 2016
    …'optional'"
    
    This reverts commit 9fe381b.
    
    This is part of a rever of a range of commits 9fe381b..8566e8b, which are causing crashes in certain cases.
  2. Revert "Move union field requiredness checking earlier"

    andrewcox committed Aug 29, 2016
    This reverts commit 8ac3925.
    
    This is part of a rever of a range of commits 9fe381b..8566e8b, which are causing crashes in certain cases.
  3. Revert "Ensure no metadata errors or warnings are added after the poi…

    andrewcox committed Aug 29, 2016
    …nt they are thrown"
    
    This reverts commit 4d3f593.
    
    This is part of a rever of a range of commits 9fe381b..8566e8b, which are causing crashes in certain cases.
  4. Revert "Comment on why 'optional' fields aren't allowed in unions"

    andrewcox committed Aug 29, 2016
    This reverts commit 8566e8b.
    
    This is part of a rever of a range of commits 9fe381b..8566e8b, which are causing crashes in certain cases.
Commits on Aug 12, 2016
  1. Declare thrown exceptions for ThriftEventHandler and ContextChain met…

    Tomas Vaskevicius
    Tomas Vaskevicius committed Aug 12, 2016
    …hods
Commits on Jul 19, 2016
Commits on Jul 15, 2016
  1. Tweaks to ThriftCodecModule

    jesboat committed Jul 15, 2016
    Summary:
    
    Remove the `binder.disableCircularProxies()` and
    `binder.requireExplicitBindings()` calls from ThriftCodecModule. They're not
    required by ThriftCodecModule, but due to the way Guice works they are
    propagated to sibling modules. This forces applications which want to use
    ThriftCodecModule to either forego implicit bindings or embed their
    ThriftCodecModule instance inside a child injector or private module, which
    somewhat defeats the point of having a shared ThriftCodecModule.
    
    Test plan: code review
    
    Reviewers: @martint, @dain, @andrewcox
    
    Cc: @cairnsjr