Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

[UI] Revert network request changes for the web view controller.

Adding support for network status isn't as simple as it might seem
for this controller. If the controller is popped off the stack,
for example, we'll never get enough request stopped messages to
stop the indicator, resulting in a permanent loading state for the
app.

Barring a proper solution to this problem, for now we'll leave it
to the controller to display the fact that it is loading.
  • Loading branch information...
commit d51a44946fa3d5bd322462824f4d9ae596346045 1 parent 532e107
@jverkoey jverkoey authored
Showing with 0 additions and 2 deletions.
  1. +0 −2  src/Three20UI/Sources/TTWebController.m
View
2  src/Three20UI/Sources/TTWebController.m
@@ -317,7 +317,6 @@ - (void)webViewDidStartLoad:(UIWebView*)webView {
if (!self.navigationItem.rightBarButtonItem) {
[self.navigationItem setRightBarButtonItem:_activityItem animated:YES];
}
- TTNetworkRequestStarted();
[_toolbar replaceItemWithTag:3 withItem:_stopButton];
_backButton.enabled = [_webView canGoBack];
_forwardButton.enabled = [_webView canGoForward];
@@ -327,7 +326,6 @@ - (void)webViewDidStartLoad:(UIWebView*)webView {
///////////////////////////////////////////////////////////////////////////////////////////////////
- (void)webViewDidFinishLoad:(UIWebView*)webView {
TT_RELEASE_SAFELY(_loadingURL);
- TTNetworkRequestStopped();
self.title = [_webView stringByEvaluatingJavaScriptFromString:@"document.title"];
if (self.navigationItem.rightBarButtonItem == _activityItem) {
[self.navigationItem setRightBarButtonItem:nil animated:YES];

1 comment on commit d51a449

@steipete

i'd count the activities internally and just call TTNetworkRequestStarted/Stopped once.

Please sign in to comment.
Something went wrong with that request. Please try again.