Fix layout bug table image item cell #432

Closed
wants to merge 1 commit into
from

2 participants

@jverkoey

Factored out method to choose the font and use that for height calculations and in setObject

@diederich diederich [UI] fixed layout bug in TTTableImageItemCell
factored out method to choose the font
and use that for height calculations and in setObject
e39fd83
@jverkoey

Which bug is this fixing?

@diederich

the cell uses 2 different fonts the different table items it handles, but height calculation was solely based on TTSTYLEVAR(tableSmallFont).
To fix it, the decision which font to use was factored out and is now used in height calculation (+heightFor...) and during configuration (setObject:)

@diederich

better commit message might be:
[UI] Fix height calculation of TTTableImageItems'

@jverkoey

Ah cool, that makes sense now :)

@jverkoey

Does this commit fix any known issue?

@diederich

was reported on IRC by dwery...

@jverkoey

Ah cool, was just curious whether there were any issues to close, thanks!

@jverkoey

Merge branch 'fix-layout-bug-tableImageItemCell' into development

Closed by 2712bf0.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment