don't swap Tableview's datasource #777

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@diederich

This patch removes swapping away the datasource of a tableview while the model is not shown. Instead it just sets the tableView's hidden property to YES.

Removing and re-adding the datasource is pretty much just a bag of hurt. E.g. it can happen that during model changes, the datasource gets replaced. If this happens, the tableView's beginUpdates and endUpdates work with different datasources (and thus crashes pretty much all the time).

@diederich diederich [UI] don't swap datasources
This patch removes swapping away the datasource of a tableview while the model is not shown. Instead it just sets the tableView's hidden property to YES.

Removing and reading the datasource is pretty much just a bag of hurt. E.g. it can happen that during model changes, the datasource gets replaced. If this happens, the tableView's beginUpdates and endUpdates work with different datasources (and thus crashes pretty much all the time).
cc715b0
@jamesgpearce

Facebook has not maintained or supported Three20 for some time, and we are closing its old and outstanding pull requests.

Many, many thanks for your support of the project. If you have any further questions, please don't hesitate to let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment