Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Add support for XML parsing through GDataXML (Development branch) #794

Closed
wants to merge 32 commits into from

5 participants

@mkhurramali

This is the same pull request as #789, but now pointing to the development branch instead of the master branch.

I have added support to extThree20XML for parsing XML documents using GDataXML.

@diederich

#elif?
There should probably be only 1 implementation

@diederich

see above.
What about putting an #error in the last #else branch, so it's clear that at least one of them need to be defined.

@diederich

is the libxml2 include directory needed in all projects now? What about including it only in the GDataXML part?

Fixed. There is no way to update HEADER_SEARCH_PATHS, so introduced a new variable that libraries can set their specific include requirements to.

@diederich

I could not figure out a simple way of adding it here, without negatively impacting other defines (like DEBUG). I have instead added this define in the *_Prefix.pch files.

@diederich

What about adding EXTXML_GDATAXML in here?

I could not figure out a simple way of adding it here, without negatively impacting other defines (like DEBUG). I have instead added this define in the *_Prefix.pch files.

Please note that extThree20JSON was adding these defines in project.pbxproj file as I had also done. I think putting them in *_Prefix.pch file is better as it gives more visibility.

@diederich

The header are already set in the xcconfig file. We might want to remove them here..

Fixed. Thanks!

@mkhurramali mkhurramali closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 21, 2011
  1. @jwang

    Merge pull request #616 from facebook/development

    jwang authored
    Release Three20 v1.0.7
Commits on Aug 2, 2011
  1. @jwang

    Merge pull request #635 from facebook/development

    jwang authored
    Release Three20 v1.0.8
Commits on Sep 13, 2011
  1. @jwang

    Merge pull request #684 from facebook/development

    jwang authored
    Three20 1.0.9
Commits on Jan 5, 2012
  1. @diederich

    Merge pull request #739 from facebook/development

    diederich authored
    [Release] Three20 1.0.10
Commits on Feb 7, 2012
  1. @tonklon

    Merge pull request #771 from facebook/development

    tonklon authored
    [Release] Three20 1.0.11
Commits on Mar 22, 2012
  1. @mkhurramali
Commits on Mar 26, 2012
  1. @mkhurramali
Commits on Mar 28, 2012
  1. @mkhurramali

    Cleaned up configurations.

    mkhurramali authored
Commits on Apr 26, 2012
  1. @mkhurramali
  2. @mkhurramali
  3. @mkhurramali

    Fixed formatting

    mkhurramali authored
  4. @mkhurramali

    Fixed formatting

    mkhurramali authored
  5. @mkhurramali

    Fixed formatting

    mkhurramali authored
  6. @mkhurramali

    Fixed formatting

    mkhurramali authored
Commits on Jun 6, 2012
  1. @mkhurramali

    Import facebook client

    mkhurramali authored
Commits on Jun 8, 2012
  1. New files for Facebook Statuses Calls

    Khurram Ali authored
Commits on Jun 15, 2012
  1. Object Files

    Khurram Ali authored
  2. Update FbConnection

    Khurram Ali authored
  3. Update FbConnection

    Khurram Ali authored
Commits on Jun 21, 2012
  1. @riksof-rizwan

    Update development

    riksof-rizwan authored
  2. New files added related to facebook objects

    Khurram Ali authored
  3. Merge branch 'development' of https://github.com/RIKSOF/three20 into …

    Khurram Ali authored
    …development
Commits on Jun 22, 2012
  1. Adding readme file

    Khurram Ali authored
  2. Updates

    Khurram Ali authored
  3. @riksof-rizwan

    Update development

    riksof-rizwan authored
  4. @riksof-rizwan

    Update development

    riksof-rizwan authored
  5. @riksof-rizwan

    Update development

    riksof-rizwan authored
  6. @riksof-rizwan

    Update development

    riksof-rizwan authored
  7. New files and updates

    Khurram Ali authored
Commits on Jul 26, 2012
  1. Deleted svn files

    Ozair Kafray authored
Commits on Jul 27, 2012
  1. Merge branch 'master' into development

    Ozair Kafray authored
Something went wrong with that request. Please try again.