Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup some FlowFixMe and enable RecoilValue's for family parameters #1740

Closed
wants to merge 2 commits into from

Conversation

drarmstr
Copy link
Contributor

Summary:
Cleanup some $FlowFixMe's

Update RecoilValue's so they can be used in family parameters

Differential Revision: D35688664

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Apr 15, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D35688664

drarmstr added a commit to drarmstr/Recoil that referenced this pull request Apr 15, 2022
…facebookexperimental#1740)

Summary:
Pull Request resolved: facebookexperimental#1740

Cleanup some `$FlowFixMe`'s

Update `RecoilValue`'s so they can be used in family parameters

Differential Revision: D35688664

fbshipit-source-id: e513aca8fafbac1ddf085489dae38525236ac013
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D35688664

drarmstr added a commit to drarmstr/Recoil that referenced this pull request Apr 15, 2022
…facebookexperimental#1740)

Summary:
Pull Request resolved: facebookexperimental#1740

Cleanup some `$FlowFixMe`'s

Update `RecoilValue`'s so they can be used in family parameters

Differential Revision: D35688664

fbshipit-source-id: 0e20942efb8b62fbe8407962b2b94a17fc4faadb
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D35688664

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D35688664

drarmstr added a commit to drarmstr/Recoil that referenced this pull request Apr 19, 2022
…facebookexperimental#1740)

Summary:
Pull Request resolved: facebookexperimental#1740

Cleanup some `$FlowFixMe`'s

Update `RecoilValue`'s so they can be used in family parameters

Differential Revision: D35688664

fbshipit-source-id: dbcf517bc632f12bfd0f5316570d28ad342b45ed
drarmstr added a commit to drarmstr/Recoil that referenced this pull request May 11, 2022
…facebookexperimental#1740)

Summary:
Pull Request resolved: facebookexperimental#1740

Cleanup some `$FlowFixMe`'s

Update `RecoilValue`'s so they can be used in family parameters

Differential Revision: https://www.internalfb.com/diff/D35688664?entry_point=27

fbshipit-source-id: 96f4886f02b17c4517b15db9e2a11399835ee234
Summary: Run the TypeScript tests before the more expensive unit tests for lower latency feedback for TypeScript errors when exporting diffs to GitHub.

Differential Revision: D35657926

fbshipit-source-id: c36e6fcc286e66361dc463b134e70cfed6474d2d
…facebookexperimental#1740)

Summary:
Pull Request resolved: facebookexperimental#1740

Cleanup some `$FlowFixMe`'s

Update `RecoilValue`'s so they can be used in family parameters

Reviewed By: mondaychen

Differential Revision: D35688664

fbshipit-source-id: d885d4a3543b6a1a6314a787f3b53384d542f32f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D35688664

@drarmstr drarmstr deleted the export-D35688664 branch June 8, 2022 20:44
AlexGuz23 pushed a commit to AlexGuz23/Recoil that referenced this pull request Nov 3, 2022
… (#1740)

Summary:
Pull Request resolved: facebookexperimental/Recoil#1740

Cleanup some `$FlowFixMe`'s

Update `RecoilValue`'s so they can be used in family parameters

Reviewed By: mondaychen

Differential Revision: D35688664

fbshipit-source-id: e62e6d1c1c3c676e58a11dae93c89f0d2df765b8
snipershooter0701 pushed a commit to snipershooter0701/Recoil that referenced this pull request Mar 5, 2023
… (#1740)

Summary:
Pull Request resolved: facebookexperimental/Recoil#1740

Cleanup some `$FlowFixMe`'s

Update `RecoilValue`'s so they can be used in family parameters

Reviewed By: mondaychen

Differential Revision: D35688664

fbshipit-source-id: e62e6d1c1c3c676e58a11dae93c89f0d2df765b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request fb-exported TypeScript / Flow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants