Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose Flow types again #1857

Closed
wants to merge 1 commit into from

Conversation

FezVrasta
Copy link
Contributor

@FezVrasta FezVrasta commented Jun 9, 2022

Fixes #1856

edit: it looks like the recoil-shared imports are still broken with this PR.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2022
@drarmstr drarmstr added bug Something isn't working TypeScript / Flow labels Jun 9, 2022
@facebook-github-bot
Copy link
Contributor

@mondaychen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@FezVrasta
Copy link
Contributor Author

Any ETA on when this will get merged & released please?

@mondaychen
Copy link
Contributor

Sorry for the delay (performance / planning season 😢 ). Will land this by end of this week

@facebook-github-bot
Copy link
Contributor

@mondaychen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mrtnzlml
Copy link

Awesome! Thank you very much @FezVrasta! 👏

snipershooter0701 pushed a commit to snipershooter0701/Recoil that referenced this pull request Mar 5, 2023
Summary:
Fixes facebookexperimental/Recoil#1856

edit: it looks like the `recoil-shared` imports are still broken with this PR.

Pull Request resolved: facebookexperimental/Recoil#1857

Reviewed By: drarmstr

Differential Revision: D37069495

Pulled By: mondaychen

fbshipit-source-id: 26a1442b69e644d9a99dcaa15222446ce42ac5a0
eagle2722 added a commit to eagle2722/Recoil that referenced this pull request Sep 21, 2024
Summary:
Fixes facebookexperimental/Recoil#1856

edit: it looks like the `recoil-shared` imports are still broken with this PR.

Pull Request resolved: facebookexperimental/Recoil#1857

Reviewed By: drarmstr

Differential Revision: D37069495

Pulled By: mondaychen

fbshipit-source-id: 26a1442b69e644d9a99dcaa15222446ce42ac5a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. TypeScript / Flow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flow types are not exposed anymore
5 participants