This repository was archived by the owner on Jan 1, 2025. It is now read-only.
fix: expose Flow types again #1857
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
@mondaychen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
Any ETA on when this will get merged & released please? |
Contributor
|
Sorry for the delay (performance / planning season 😢 ). Will land this by end of this week |
Contributor
|
@mondaychen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Awesome! Thank you very much @FezVrasta! 👏 |
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Fixes facebookexperimental/Recoil#1856 edit: it looks like the `recoil-shared` imports are still broken with this PR. Pull Request resolved: facebookexperimental/Recoil#1857 Reviewed By: drarmstr Differential Revision: D37069495 Pulled By: mondaychen fbshipit-source-id: 26a1442b69e644d9a99dcaa15222446ce42ac5a0
eagle2722
added a commit
to eagle2722/Recoil
that referenced
this pull request
Sep 21, 2024
Summary: Fixes facebookexperimental/Recoil#1856 edit: it looks like the `recoil-shared` imports are still broken with this PR. Pull Request resolved: facebookexperimental/Recoil#1857 Reviewed By: drarmstr Differential Revision: D37069495 Pulled By: mondaychen fbshipit-source-id: 26a1442b69e644d9a99dcaa15222446ce42ac5a0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1856
edit: it looks like the
recoil-sharedimports are still broken with this PR.