This repository was archived by the owner on Jan 1, 2025. It is now read-only.
Fix useRecoilSnapshot() with Fast Refresh#1891
Closed
drarmstr wants to merge 1 commit into
Closed
Conversation
Summary: Fix support for `useRecoilSnapshot()` when Fast Refresh. (Note this is dev-only) React's "Fast Refresh" will detect changes to source and re-load and re-render components with the new implementation. However, it appears to call the new render, then the previous effects cleanup handler, then the new effects. This seems strange and caused the snapshot to be released before the new effect retained it. Don't expect behviour change from React, so workaround is to defer the release with `setTimeout()` so the new effect after the fast refresh has a chance to retain it before the old effect cleanup releases it. Differential Revision: D37475404 fbshipit-source-id: 3797eecc1775d3e883b90897e6e00fe0453126b8
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37475404 |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Jun 28, 2022
Summary: Update changelog for facebookexperimental#1891 Differential Revision: D37503573 fbshipit-source-id: 9ef7cbffcddb9f0a36d6da56843ae041aaa1cd10
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
ghost
mentioned this pull request
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#1891 Fix support for `useRecoilSnapshot()` when Fast Refresh. (Note this is dev-only) React's "Fast Refresh" will detect changes to source and re-load and re-render components with the new implementation. However, it appears to call the new render, then the previous effects cleanup handler, then the new effects. This seems strange and caused the snapshot to be released before the new effect retained it. Don't expect behviour change from React, so workaround is to defer the release with `setTimeout()` so the new effect after the fast refresh has a chance to retain it before the old effect cleanup releases it. Reviewed By: habond Differential Revision: D37475404 fbshipit-source-id: a570324864a688b49f0fcfd55459b54e7abdef39
eagle2722
added a commit
to eagle2722/Recoil
that referenced
this pull request
Sep 21, 2024
Summary: Pull Request resolved: facebookexperimental/Recoil#1891 Fix support for `useRecoilSnapshot()` when Fast Refresh. (Note this is dev-only) React's "Fast Refresh" will detect changes to source and re-load and re-render components with the new implementation. However, it appears to call the new render, then the previous effects cleanup handler, then the new effects. This seems strange and caused the snapshot to be released before the new effect retained it. Don't expect behviour change from React, so workaround is to defer the release with `setTimeout()` so the new effect after the fast refresh has a chance to retain it before the old effect cleanup releases it. Reviewed By: habond Differential Revision: D37475404 fbshipit-source-id: a570324864a688b49f0fcfd55459b54e7abdef39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix support for
useRecoilSnapshot()when Fast Refresh. (Note this is dev-only)React's "Fast Refresh" will detect changes to source and re-load and re-render components with the new implementation. However, it appears to call the new render, then the previous effects cleanup handler, then the new effects. This seems strange and caused the snapshot to be released before the new effect retained it. Don't expect behviour change from React, so workaround is to defer the release with
setTimeout()so the new effect after the fast refresh has a chance to retain it before the old effect cleanup releases it.Differential Revision: D37475404