Refine - remove 'native' from package.json #1931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no `native` folder in the release but it was referred to in the package file, which causes errors for react-native.
facebook-github-bot
added
the
CLA Signed
|
@drarmstr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
What has happened here? Does that mean it's being accepted by some process outside Github? |
|
Yes, it was imported to our internal source repository which is the source of truth for the code base. When changes land in that repository then they are replicated back out to the GitHub repository. |
Closed
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Aug 16, 2022
Summary: Refine 0.1.1 release: - Remove reference to `native` directory in `package.json` to cleanup errors for `react-native` (facebookexperimental#1931) - Export Path class for custom checkers (facebookexperimental#1950, facebookexperimental#1956) Reviewed By: bsouthga Differential Revision: D38764896 fbshipit-source-id: f8d6c35fc5c92c285182586e3b725d03c65bcf59
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Aug 17, 2022
Summary: Pull Request resolved: facebookexperimental#1959 Refine 0.1.1 release: - Remove reference to `native` directory in `package.json` to cleanup errors for `react-native` (facebookexperimental#1931) - Export Path class for custom checkers (facebookexperimental#1950, facebookexperimental#1956) Reviewed By: bsouthga Differential Revision: D38764896 fbshipit-source-id: dedf75327d5b4103f92ab421240704f73786e742
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
Summary: Pull Request resolved: #1959 Refine 0.1.1 release: - Rename `boolean()` export to `bool()` since `boolean` is a reserved word (#1922, #1962) - Remove reference to `native` directory in `package.json` to cleanup errors for `react-native`. (#1931) - Export `Path` class for custom checkers. (#1950, #1956) - Extend the failure message of `union()` and `or()` with each type. (#1961) Reviewed By: bsouthga Differential Revision: D38764896 fbshipit-source-id: 5eb0327ab9034f3f0802796d986fd6e7df28f05c
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: There is no `native` folder in the release but it was referred to in the package file, which causes errors for react-native. Pull Request resolved: facebookexperimental/Recoil#1931 Reviewed By: mondaychen Differential Revision: D38526707 Pulled By: drarmstr fbshipit-source-id: b18baeac1f9d1a68c404b7eba3c2aaf46c005359
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no
nativefolder in the release but it was referred to in the package file, which causes errors for react-native.