Update for browser change in setTimeout() behavior #1943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Resolves facebookexperimental#1936 It appears that some browsers changed behavior for `setTimeout(..., 0);`. The timeout previously had a minimum value of 1 but now has new behavior for 0. This caused code ordering changes which broke snapshot auto release for some browsers, though likely only for dev mode when React Fast Refresh was being used (tested by Vija02 with Chrome 104.0.5112.79 and Firefox 103.0.1 using NextJS dev mode). Update the timeouts to workaround this issue. Differential Revision: D38591482 fbshipit-source-id: 278f101b4734d039409abc963bc0d1df9277a748
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D38591482 |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Aug 10, 2022
…tal#1943) Summary: Pull Request resolved: facebookexperimental#1943 Resolves facebookexperimental#1936 It appears that some browsers changed behavior for `setTimeout(..., 0);`. The timeout previously had a minimum value of 1 but now has new behavior for 0. This caused code ordering changes which broke snapshot auto release for some browsers, though likely only for dev mode when React Fast Refresh was being used (tested by Vija02 with Chrome 104.0.5112.79 and Firefox 103.0.1 using NextJS dev mode). Update the timeouts to workaround this issue. Differential Revision: https://www.internalfb.com/diff/D38591482?entry_point=27 fbshipit-source-id: 584741ec055bd9f1d34adf0fe721191d78e49d9b
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#1943 Resolves #1936 It appears that some browsers changed behavior for `setTimeout(..., 0);`. The timeout previously had a minimum value of 1 but now has new behavior for 0. This caused code ordering changes which broke snapshot auto release for some browsers, though likely only for dev mode when React Fast Refresh was being used (tested by Vija02 with Chrome 104.0.5112.79 and Firefox 103.0.1 using NextJS dev mode). Update the timeouts to workaround this issue. Reviewed By: mrv1k Differential Revision: D38591482 fbshipit-source-id: f868959a4668676c1cd896b95aed6f8da4544237
eagle2722
added a commit
to eagle2722/Recoil
that referenced
this pull request
Sep 21, 2024
Summary: Pull Request resolved: facebookexperimental/Recoil#1943 Resolves #1936 It appears that some browsers changed behavior for `setTimeout(..., 0);`. The timeout previously had a minimum value of 1 but now has new behavior for 0. This caused code ordering changes which broke snapshot auto release for some browsers, though likely only for dev mode when React Fast Refresh was being used (tested by Vija02 with Chrome 104.0.5112.79 and Firefox 103.0.1 using NextJS dev mode). Update the timeouts to workaround this issue. Reviewed By: mrv1k Differential Revision: D38591482 fbshipit-source-id: f868959a4668676c1cd896b95aed6f8da4544237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Resolves #1936
It appears that some browsers changed behavior for
setTimeout(..., 0);. The timeout previously had a minimum value of 1 but now has new behavior for 0. This caused code ordering changes which broke snapshot auto release for some browsers, though likely only for dev mode when React Fast Refresh was being used (tested by Vija02 with Chrome 104.0.5112.79 and Firefox 103.0.1 using NextJS dev mode). Update the timeouts to workaround this issue.Differential Revision: D38591482