-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export Path class for custom checkers #1956
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Resolves facebookexperimental#1950 Refine previously exported the `Path` type, but now actually export the `Path` class for custom checkers. Differential Revision: D38753941 fbshipit-source-id: decdfca6f670704237a19afd671d303266386760
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
labels
Aug 16, 2022
This pull request was exported from Phabricator. Differential Revision: D38753941 |
Closed
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Aug 16, 2022
Summary: Refine 0.1.1 release: - Remove reference to `native` directory in `package.json` to cleanup errors for `react-native` (facebookexperimental#1931) - Export Path class for custom checkers (facebookexperimental#1950, facebookexperimental#1956) Reviewed By: bsouthga Differential Revision: D38764896 fbshipit-source-id: f8d6c35fc5c92c285182586e3b725d03c65bcf59
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Aug 17, 2022
Summary: Pull Request resolved: facebookexperimental#1959 Refine 0.1.1 release: - Remove reference to `native` directory in `package.json` to cleanup errors for `react-native` (facebookexperimental#1931) - Export Path class for custom checkers (facebookexperimental#1950, facebookexperimental#1956) Reviewed By: bsouthga Differential Revision: D38764896 fbshipit-source-id: dedf75327d5b4103f92ab421240704f73786e742
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
Summary: Pull Request resolved: #1959 Refine 0.1.1 release: - Rename `boolean()` export to `bool()` since `boolean` is a reserved word (#1922, #1962) - Remove reference to `native` directory in `package.json` to cleanup errors for `react-native`. (#1931) - Export `Path` class for custom checkers. (#1950, #1956) - Extend the failure message of `union()` and `or()` with each type. (#1961) Reviewed By: bsouthga Differential Revision: D38764896 fbshipit-source-id: 5eb0327ab9034f3f0802796d986fd6e7df28f05c
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#1956 Resolves #1950 Refine previously exported the `Path` type, but now actually export the `Path` class for custom checkers. Reviewed By: bsouthga Differential Revision: D38753941 fbshipit-source-id: 099eb6b596ad6cac2913b1d83cc695fcc1440a54
eagle2722
added a commit
to eagle2722/Recoil
that referenced
this pull request
Sep 21, 2024
Summary: Pull Request resolved: facebookexperimental/Recoil#1956 Resolves #1950 Refine previously exported the `Path` type, but now actually export the `Path` class for custom checkers. Reviewed By: bsouthga Differential Revision: D38753941 fbshipit-source-id: 099eb6b596ad6cac2913b1d83cc695fcc1440a54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build / infra
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Component: refine
related to refine
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Resolves #1950
Refine previously exported the
Path
type, but now actually export thePath
class for custom checkers.Differential Revision: D38753941