Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Path class for custom checkers #1956

Closed

Conversation

drarmstr
Copy link
Contributor

Summary:
Resolves #1950

Refine previously exported the Path type, but now actually export the Path class for custom checkers.

Differential Revision: D38753941

Summary:
Resolves facebookexperimental#1950

Refine previously exported the `Path` type, but now actually export the `Path` class for custom checkers.

Differential Revision: D38753941

fbshipit-source-id: decdfca6f670704237a19afd671d303266386760
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Aug 16, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D38753941

@drarmstr drarmstr mentioned this pull request Aug 16, 2022
drarmstr added a commit to drarmstr/Recoil that referenced this pull request Aug 16, 2022
Summary:
Refine 0.1.1 release:

- Remove reference to `native` directory in `package.json` to cleanup errors for `react-native` (facebookexperimental#1931)
- Export Path class for custom checkers (facebookexperimental#1950, facebookexperimental#1956)

Reviewed By: bsouthga

Differential Revision: D38764896

fbshipit-source-id: f8d6c35fc5c92c285182586e3b725d03c65bcf59
drarmstr added a commit to drarmstr/Recoil that referenced this pull request Aug 17, 2022
Summary:
Pull Request resolved: facebookexperimental#1959

Refine 0.1.1 release:

- Remove reference to `native` directory in `package.json` to cleanup errors for `react-native` (facebookexperimental#1931)
- Export Path class for custom checkers (facebookexperimental#1950, facebookexperimental#1956)

Reviewed By: bsouthga

Differential Revision: D38764896

fbshipit-source-id: dedf75327d5b4103f92ab421240704f73786e742
facebook-github-bot pushed a commit that referenced this pull request Aug 18, 2022
Summary:
Pull Request resolved: #1959

Refine 0.1.1 release:

- Rename `boolean()` export to `bool()` since `boolean` is a reserved word (#1922, #1962)
- Remove reference to `native` directory in `package.json` to cleanup errors for `react-native`. (#1931)
- Export `Path` class for custom checkers. (#1950, #1956)
- Extend the failure message of `union()` and `or()` with each type. (#1961)

Reviewed By: bsouthga

Differential Revision: D38764896

fbshipit-source-id: 5eb0327ab9034f3f0802796d986fd6e7df28f05c
@drarmstr drarmstr deleted the export-D38753941 branch August 18, 2022 22:41
@drarmstr drarmstr self-assigned this Aug 18, 2022
snipershooter0701 pushed a commit to snipershooter0701/Recoil that referenced this pull request Mar 5, 2023
Summary:
Pull Request resolved: facebookexperimental/Recoil#1956

Resolves #1950

Refine previously exported the `Path` type, but now actually export the `Path` class for custom checkers.

Reviewed By: bsouthga

Differential Revision: D38753941

fbshipit-source-id: 099eb6b596ad6cac2913b1d83cc695fcc1440a54
eagle2722 added a commit to eagle2722/Recoil that referenced this pull request Sep 21, 2024
Summary:
Pull Request resolved: facebookexperimental/Recoil#1956

Resolves #1950

Refine previously exported the `Path` type, but now actually export the `Path` class for custom checkers.

Reviewed By: bsouthga

Differential Revision: D38753941

fbshipit-source-id: 099eb6b596ad6cac2913b1d83cc695fcc1440a54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build / infra CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Component: refine related to refine fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@recoiljs/refine's types export Path while the library itself doesn't
2 participants