This repository was archived by the owner on Jan 1, 2025. It is now read-only.
Rename boolean() checker to bool() #1962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Resolves facebookexperimental#1922 Rename `boolean()` checker to `bool()` since `boolean` is a reserved word in JS and the export was not working for the open source build. While this might be considered a breaking API change, we can argue it's only a semantic version patch number update since the previous export didn't actually work so this is still just a bug fix. Differential Revision: D38800113 fbshipit-source-id: 69fd0e8a369fdfecf5996f306f461ae8379b0245
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D38800113 |
Closed
drarmstr
added
build / infra
Component: refine
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
Summary: Pull Request resolved: #1959 Refine 0.1.1 release: - Rename `boolean()` export to `bool()` since `boolean` is a reserved word (#1922, #1962) - Remove reference to `native` directory in `package.json` to cleanup errors for `react-native`. (#1931) - Export `Path` class for custom checkers. (#1950, #1956) - Extend the failure message of `union()` and `or()` with each type. (#1961) Reviewed By: bsouthga Differential Revision: D38764896 fbshipit-source-id: 5eb0327ab9034f3f0802796d986fd6e7df28f05c
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#1962 Resolves #1922 Rename `boolean()` checker to `bool()` since `boolean` is a reserved word in JS and the export was not working for the open source build. While this might be considered a breaking API change, we can argue it's only a semantic version patch number update since the previous export didn't actually work so this is still just a bug fix. Reviewed By: wd-fb, lwxted Differential Revision: D38800113 fbshipit-source-id: fda866b16f8742e5a5e7a15644744295e4179a57
eagle2722
added a commit
to eagle2722/Recoil
that referenced
this pull request
Sep 21, 2024
Summary: Pull Request resolved: facebookexperimental/Recoil#1962 Resolves #1922 Rename `boolean()` checker to `bool()` since `boolean` is a reserved word in JS and the export was not working for the open source build. While this might be considered a breaking API change, we can argue it's only a semantic version patch number update since the previous export didn't actually work so this is still just a bug fix. Reviewed By: wd-fb, lwxted Differential Revision: D38800113 fbshipit-source-id: fda866b16f8742e5a5e7a15644744295e4179a57
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Resolves #1922
Rename
boolean()checker tobool()sincebooleanis a reserved word in JS and the export was not working for the open source build.While this might be considered a breaking API change, we can argue it's only a semantic version patch number update since the previous export didn't actually work so this is still just a bug fix.
Differential Revision: D38800113