Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved workaround for backward compatibility with renderers built for < React 18 support #2010

Closed
wants to merge 2 commits into from

Conversation

drarmstr
Copy link
Contributor

Summary: An improved workaround for Recoil to have backward compatibility with React renderers built before React 18 support when used with React 18. While this may technically be a user error we would like to avoid breaking internal or open source applications that are using React 18 and have not yet upgraded all of their renderers.

Differential Revision: D39586744

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Sep 16, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39586744

@drarmstr drarmstr self-assigned this Sep 16, 2022
Summary:
Suppress linter warnings for legacy rendering modes.

Also update https://github.com/aaronabramov/eslint-plugin-fb-www

Differential Revision: https://www.internalfb.com/diff/D39512879?entry_point=27

fbshipit-source-id: 20c105f02bb7a222175e6d0bc5c4c02c31874281
…or < React 18 support (facebookexperimental#2010)

Summary:
Pull Request resolved: facebookexperimental#2010

An improved workaround for Recoil to have backward compatibility with React renderers built before React 18 support when used with React 18.  While this may technically be a user error we would like to avoid breaking internal or open source applications that are using React 18 and have not yet upgraded all of their renderers.

Log detected Renderer version mismatches using `recoverableViolation()`, but only once per module runtime.

Differential Revision: D39586744

fbshipit-source-id: 74fc98fb32f0061e6f2ece46e4629eb68a835c31
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39586744

snipershooter0701 pushed a commit to snipershooter0701/Recoil that referenced this pull request Mar 5, 2023
…or < React 18 support (#2010)

Summary:
Pull Request resolved: facebookexperimental/Recoil#2010

An improved workaround for Recoil to have backward compatibility with React renderers built before React 18 support when used with React 18.  While this may technically be a user error we would like to avoid breaking internal or open source applications that are using React 18 and have not yet upgraded all of their renderers.

Log detected Renderer version mismatches using `recoverableViolation()`, but only once per module runtime.

Reviewed By: davidmccabe

Differential Revision: D39586744

fbshipit-source-id: 1dbe5dbf3b33f30d49891ae74e4c078fe7c4d05f
eagle2722 added a commit to eagle2722/Recoil that referenced this pull request Sep 21, 2024
…or < React 18 support (#2010)

Summary:
Pull Request resolved: facebookexperimental/Recoil#2010

An improved workaround for Recoil to have backward compatibility with React renderers built before React 18 support when used with React 18.  While this may technically be a user error we would like to avoid breaking internal or open source applications that are using React 18 and have not yet upgraded all of their renderers.

Log detected Renderer version mismatches using `recoverableViolation()`, but only once per module runtime.

Reviewed By: davidmccabe

Differential Revision: D39586744

fbshipit-source-id: 1dbe5dbf3b33f30d49891ae74e4c078fe7c4d05f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants