This repository was archived by the owner on Jan 1, 2025. It is now read-only.
Improved workaround for backward compatibility with renderers built for < React 18 support#2010
Closed
drarmstr wants to merge 2 commits intofacebookexperimental:mainfrom
Closed
Improved workaround for backward compatibility with renderers built for < React 18 support#2010drarmstr wants to merge 2 commits intofacebookexperimental:mainfrom
drarmstr wants to merge 2 commits intofacebookexperimental:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39586744 |
Summary: Suppress linter warnings for legacy rendering modes. Also update https://github.com/aaronabramov/eslint-plugin-fb-www Differential Revision: https://www.internalfb.com/diff/D39512879?entry_point=27 fbshipit-source-id: 20c105f02bb7a222175e6d0bc5c4c02c31874281
…or < React 18 support (facebookexperimental#2010) Summary: Pull Request resolved: facebookexperimental#2010 An improved workaround for Recoil to have backward compatibility with React renderers built before React 18 support when used with React 18. While this may technically be a user error we would like to avoid breaking internal or open source applications that are using React 18 and have not yet upgraded all of their renderers. Log detected Renderer version mismatches using `recoverableViolation()`, but only once per module runtime. Differential Revision: D39586744 fbshipit-source-id: 74fc98fb32f0061e6f2ece46e4629eb68a835c31
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39586744 |
drarmstr
force-pushed
the
export-D39586744
branch
from
1cb6ec4 to
d9dabbb
Compare
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
…or < React 18 support (#2010) Summary: Pull Request resolved: facebookexperimental/Recoil#2010 An improved workaround for Recoil to have backward compatibility with React renderers built before React 18 support when used with React 18. While this may technically be a user error we would like to avoid breaking internal or open source applications that are using React 18 and have not yet upgraded all of their renderers. Log detected Renderer version mismatches using `recoverableViolation()`, but only once per module runtime. Reviewed By: davidmccabe Differential Revision: D39586744 fbshipit-source-id: 1dbe5dbf3b33f30d49891ae74e4c078fe7c4d05f
eagle2722
added a commit
to eagle2722/Recoil
that referenced
this pull request
Sep 21, 2024
…or < React 18 support (#2010) Summary: Pull Request resolved: facebookexperimental/Recoil#2010 An improved workaround for Recoil to have backward compatibility with React renderers built before React 18 support when used with React 18. While this may technically be a user error we would like to avoid breaking internal or open source applications that are using React 18 and have not yet upgraded all of their renderers. Log detected Renderer version mismatches using `recoverableViolation()`, but only once per module runtime. Reviewed By: davidmccabe Differential Revision: D39586744 fbshipit-source-id: 1dbe5dbf3b33f30d49891ae74e4c078fe7c4d05f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: An improved workaround for Recoil to have backward compatibility with React renderers built before React 18 support when used with React 18. While this may technically be a user error we would like to avoid breaking internal or open source applications that are using React 18 and have not yet upgraded all of their renderers.
Differential Revision: D39586744