Skip to content
This repository was archived by the owner on Jan 1, 2025. It is now read-only.

improve API / naming for runtime env settings, expose through public recoil API#2046

Closed
wd-fb wants to merge 1 commit intofacebookexperimental:mainfrom
wd-fb:export-D39797419
Closed

improve API / naming for runtime env settings, expose through public recoil API#2046
wd-fb wants to merge 1 commit intofacebookexperimental:mainfrom
wd-fb:export-D39797419

Conversation

@wd-fb
Copy link
Copy Markdown
Contributor

@wd-fb wd-fb commented Sep 30, 2022

Summary: followup on previous diff

Differential Revision: D39797419

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Sep 30, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D39797419

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D39797419

wd-fb pushed a commit to wd-fb/Recoil that referenced this pull request Oct 3, 2022
…recoil API (facebookexperimental#2046)

Summary:
Pull Request resolved: facebookexperimental#2046

followup on previous diff

Reviewed By: drarmstr

Differential Revision: D39797419

fbshipit-source-id: 82267c17371441ef5d95978ab3411234aa1c567f
@wd-fb wd-fb force-pushed the export-D39797419 branch from 97d0a95 to 3ad9ae6 Compare October 3, 2022 21:08
@drarmstr drarmstr added the enhancement New feature or request label Oct 4, 2022
wd-fb pushed a commit to wd-fb/Recoil that referenced this pull request Oct 4, 2022
…recoil API (facebookexperimental#2046)

Summary:
Pull Request resolved: facebookexperimental#2046

followup on previous diff

Reviewed By: drarmstr

Differential Revision: D39797419

fbshipit-source-id: e40033140b88ae1962557263818daa2b4adaaf6f
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D39797419

@wd-fb wd-fb force-pushed the export-D39797419 branch from 3ad9ae6 to 7878ad1 Compare October 4, 2022 17:00
wd-fb pushed a commit to wd-fb/Recoil that referenced this pull request Oct 4, 2022
…recoil API (facebookexperimental#2046)

Summary:
Pull Request resolved: facebookexperimental#2046

followup on previous diff

Reviewed By: drarmstr

Differential Revision: D39797419

fbshipit-source-id: 71fcb6177562a38c45d8078d61f8bb3decccf0e2
@wd-fb wd-fb force-pushed the export-D39797419 branch from 7878ad1 to 1e25c7d Compare October 4, 2022 21:42
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D39797419

wd-fb pushed a commit to wd-fb/Recoil that referenced this pull request Oct 4, 2022
…recoil API (facebookexperimental#2046)

Summary:
Pull Request resolved: facebookexperimental#2046

followup on previous diff

Reviewed By: drarmstr

Differential Revision: D39797419

fbshipit-source-id: 8fa586d8e9d85fd9256c94a8dfba92f800896a68
@wd-fb wd-fb force-pushed the export-D39797419 branch from 1e25c7d to 91825b4 Compare October 4, 2022 21:50
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D39797419

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D39797419

wd-fb pushed a commit to wd-fb/Recoil that referenced this pull request Oct 5, 2022
…recoil API (facebookexperimental#2046)

Summary:
Pull Request resolved: facebookexperimental#2046

followup on previous diff

Reviewed By: drarmstr

Differential Revision: D39797419

fbshipit-source-id: 13d60574a7070403633811f129f12447822d0d87
@wd-fb wd-fb force-pushed the export-D39797419 branch from 91825b4 to 2636d71 Compare October 5, 2022 18:28
…recoil API (facebookexperimental#2046)

Summary:
Pull Request resolved: facebookexperimental#2046

followup on previous diff

Reviewed By: drarmstr

Differential Revision: D39797419

fbshipit-source-id: d8f3accfdfdded7db40b81094dcc16664fff9aad
@wd-fb wd-fb force-pushed the export-D39797419 branch from 47e2eaa to 95b3456 Compare October 5, 2022 19:35
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D39797419

@brahn
Copy link
Copy Markdown

brahn commented Oct 14, 2022

@drarmstr @wd-fb thanks for pushing this over the finish line!

snipershooter0701 pushed a commit to snipershooter0701/Recoil that referenced this pull request Mar 5, 2023
…recoil API (#2046)

Summary:
Pull Request resolved: facebookexperimental/Recoil#2046

followup on previous diff

Reviewed By: drarmstr

Differential Revision: D39797419

fbshipit-source-id: f91a83691b88ffb4aa8fcbac4330b8a5adfce871
eagle2722 added a commit to eagle2722/Recoil that referenced this pull request Sep 21, 2024
…recoil API (#2046)

Summary:
Pull Request resolved: facebookexperimental/Recoil#2046

followup on previous diff

Reviewed By: drarmstr

Differential Revision: D39797419

fbshipit-source-id: f91a83691b88ffb4aa8fcbac4330b8a5adfce871
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants