improve API / naming for runtime env settings, expose through public recoil API #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39797419 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D39797419 |
wd-fb
pushed a commit
to wd-fb/Recoil
that referenced
this pull request
Oct 3, 2022
…recoil API (facebookexperimental#2046) Summary: Pull Request resolved: facebookexperimental#2046 followup on previous diff Reviewed By: drarmstr Differential Revision: D39797419 fbshipit-source-id: 82267c17371441ef5d95978ab3411234aa1c567f
wd-fb
force-pushed
the
export-D39797419
branch
from
97d0a95
to
3ad9ae6
Compare
wd-fb
pushed a commit
to wd-fb/Recoil
that referenced
this pull request
Oct 4, 2022
…recoil API (facebookexperimental#2046) Summary: Pull Request resolved: facebookexperimental#2046 followup on previous diff Reviewed By: drarmstr Differential Revision: D39797419 fbshipit-source-id: e40033140b88ae1962557263818daa2b4adaaf6f
|
This pull request was exported from Phabricator. Differential Revision: D39797419 |
wd-fb
force-pushed
the
export-D39797419
branch
from
3ad9ae6
to
7878ad1
Compare
wd-fb
pushed a commit
to wd-fb/Recoil
that referenced
this pull request
Oct 4, 2022
…recoil API (facebookexperimental#2046) Summary: Pull Request resolved: facebookexperimental#2046 followup on previous diff Reviewed By: drarmstr Differential Revision: D39797419 fbshipit-source-id: 71fcb6177562a38c45d8078d61f8bb3decccf0e2
wd-fb
force-pushed
the
export-D39797419
branch
from
7878ad1
to
1e25c7d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39797419 |
wd-fb
pushed a commit
to wd-fb/Recoil
that referenced
this pull request
Oct 4, 2022
…recoil API (facebookexperimental#2046) Summary: Pull Request resolved: facebookexperimental#2046 followup on previous diff Reviewed By: drarmstr Differential Revision: D39797419 fbshipit-source-id: 8fa586d8e9d85fd9256c94a8dfba92f800896a68
wd-fb
force-pushed
the
export-D39797419
branch
from
1e25c7d
to
91825b4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39797419 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D39797419 |
wd-fb
pushed a commit
to wd-fb/Recoil
that referenced
this pull request
Oct 5, 2022
…recoil API (facebookexperimental#2046) Summary: Pull Request resolved: facebookexperimental#2046 followup on previous diff Reviewed By: drarmstr Differential Revision: D39797419 fbshipit-source-id: 13d60574a7070403633811f129f12447822d0d87
wd-fb
force-pushed
the
export-D39797419
branch
from
91825b4
to
2636d71
Compare
…recoil API (facebookexperimental#2046) Summary: Pull Request resolved: facebookexperimental#2046 followup on previous diff Reviewed By: drarmstr Differential Revision: D39797419 fbshipit-source-id: d8f3accfdfdded7db40b81094dcc16664fff9aad
wd-fb
force-pushed
the
export-D39797419
branch
from
47e2eaa
to
95b3456
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39797419 |
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
…recoil API (#2046) Summary: Pull Request resolved: facebookexperimental/Recoil#2046 followup on previous diff Reviewed By: drarmstr Differential Revision: D39797419 fbshipit-source-id: f91a83691b88ffb4aa8fcbac4330b8a5adfce871
eagle2722
added a commit
to eagle2722/Recoil
that referenced
this pull request
Sep 21, 2024
…recoil API (#2046) Summary: Pull Request resolved: facebookexperimental/Recoil#2046 followup on previous diff Reviewed By: drarmstr Differential Revision: D39797419 fbshipit-source-id: f91a83691b88ffb4aa8fcbac4330b8a5adfce871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: followup on previous diff
Differential Revision: D39797419