From 4f3289dcf9ea35e3dd6a8407b78a0a8c36cc2d73 Mon Sep 17 00:00:00 2001
From: laresbernardo <laresbernardo@gmail.com>
Date: Wed, 12 Apr 2023 10:39:52 -0500
Subject: [PATCH] fix: pick refresh model by error_score correctly #674

---
 R/R/refresh.R | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/R/R/refresh.R b/R/R/refresh.R
index 161ac6989..56846a7da 100644
--- a/R/R/refresh.R
+++ b/R/R/refresh.R
@@ -294,9 +294,9 @@ robyn_refresh <- function(json_file = NULL,
       ...
     )
 
-    ## Select winner model for current refresh
+    ## Select winner model for current refresh (the higher error_score the better)
     OutputCollectRF$resultHypParam <- OutputCollectRF$resultHypParam %>%
-      arrange(.data$solID, desc(.data$error_score)) %>%
+      arrange(desc(.data$error_score)) %>%
       select(.data$solID, everything()) %>%
       ungroup()
     bestMod <- OutputCollectRF$resultHypParam$solID[1]